Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Jason Nader <dev@kayoway.com>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH 0/1] nvme-pci: add quirks for Lexar NM790
Date: Wed, 22 May 2024 11:42:46 -0600	[thread overview]
Message-ID: <Zk4ulsDpokA-1RfB@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20240522155614.191849-1-dev@kayoway.com>

On Thu, May 23, 2024 at 12:56:13AM +0900, Jason Nader wrote:
> Hi,
> 
> This adds Lexar NM790 to the quirks list.
> Other drives in the model line-up already exist in the list.
> 
> Kernel logs before:
> 
> nvme nvme1: pci function 0000:03:00.0
> nvme nvme1: missing or invalid SUBNQN field.
> nvme nvme1: allocated 32 MiB host memory buffer.
> nvme nvme1: 8/0/0 default/read/poll queues
> block nvme1n1: No UUID available providing old NGUID
> 
> Kernel logs after:
> 
> nvme nvme1: pci function 0000:03:00.0
> nvme nvme1: allocated 32 MiB host memory buffer.
> nvme nvme1: 8/0/0 default/read/poll queues
> nvme nvme1: Ignoring bogus Namespace Identifiers
> 
> Other info:
> 
> >sudo nvme ns-descs /dev/nvme1n1    
> NVME Namespace Identification Descriptors NS 1:
> eui64   : 6479a74b40200c00
> nguid   : 00000000000000000000000000000000

This quirk is actually for the nvme subsystem. It has nothing to do with
namespace descriptors.

  nvme id-ctrl /dev/nvme1 | grep subnqn

I'm not even sure why we have this quirk; it just suppresses a harmless
print message; everything works the same with or without the quirk.


  parent reply	other threads:[~2024-05-22 17:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 15:56 [PATCH 0/1] nvme-pci: add quirks for Lexar NM790 Jason Nader
2024-05-22 15:56 ` [PATCH 1/1] " Jason Nader
2024-05-22 17:42 ` Keith Busch [this message]
2024-05-23  9:52   ` [PATCH 0/1] " Jason Nader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zk4ulsDpokA-1RfB@kbusch-mbp.dhcp.thefacebook.com \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dev@kayoway.com \
    --cc=hch@lst.de \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox