Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>,
	Keith Busch <kbusch@kernel.org>, Keith Busch <kbusch@meta.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] nvme-pci: allow unmanaged interrupts
Date: Tue, 21 May 2024 12:06:58 +0200	[thread overview]
Message-ID: <ZkxyQmR0cpT7-zKY@localhost.localdomain> (raw)
In-Reply-To: <87a5kjimpq.ffs@tglx>

Le Tue, May 21, 2024 at 10:38:25AM +0200, Thomas Gleixner a écrit :
> On Tue, May 21 2024 at 10:31, Ming Lei wrote:
> 
> > On Mon, May 20, 2024 at 05:37:42PM +0200, Christoph Hellwig wrote:
> >> On Sun, May 12, 2024 at 08:35:55AM +0200, Thomas Gleixner wrote:
> >> > That's expected as you pin the I/O operation on the isolated CPUs which
> >> > in turn makes them use the per CPU queue.
> >> > 
> >> > The isolated CPUs are only excluded for device management interrupts,
> >> > but not for the affinity spread of the queues.
> >> 
> >> We'll probably need a version of isolcpus that also excludes the
> >> interrupt spread given that users are asking for it.  And I'd much
> >> prefer that over adding radom module options to every driver to disable
> >> managed interrupts.
> >
> > BTW, isolcpus has been marked as deprecated, and it can't be adjust
> > runtime.
> 
> Which is far from reality as cpusets do not allow to do what isolcpus
> does today.
> 
> Also runtime adjusting managed interrupts needs way more thoughts.

I'll remove that comment (unless someone beats me at it?). We used to think
that cpusets would indeed deprecate isolcpus but for several reasons this
will never be the case.

Thanks.


  reply	other threads:[~2024-05-21 10:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10 14:14 [PATCH 1/2] genirq/affinity: remove rsvd check against minvec Keith Busch
2024-05-10 14:14 ` [PATCH 2/2] nvme-pci: allow unmanaged interrupts Keith Busch
2024-05-10 15:10   ` Christoph Hellwig
2024-05-10 16:20     ` Keith Busch
2024-05-10 23:50       ` Ming Lei
2024-05-11  0:41         ` Keith Busch
2024-05-11  0:59           ` Ming Lei
2024-05-12  6:35           ` Thomas Gleixner
2024-05-20 15:37             ` Christoph Hellwig
2024-05-20 20:34               ` Thomas Gleixner
2024-05-21  2:31               ` Ming Lei
2024-05-21  8:38                 ` Thomas Gleixner
2024-05-21 10:06                   ` Frederic Weisbecker [this message]
2024-05-13  7:33     ` Benjamin Meier
2024-05-13  8:39       ` Ming Lei
2024-05-13  8:59         ` Benjamin Meier
2024-05-13  9:25           ` Ming Lei
2024-05-13 12:33             ` Benjamin Meier
2024-05-13 13:12     ` Bart Van Assche
2024-05-10 15:15 ` [PATCH 1/2] genirq/affinity: remove rsvd check against minvec Ming Lei
2024-05-10 16:47   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZkxyQmR0cpT7-zKY@localhost.localdomain \
    --to=frederic@kernel.org \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kbusch@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ming.lei@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox