Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Kanchan Joshi <joshi.k@samsung.com>,
	axboe@kernel.dk, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, javier.gonz@samsung.com,
	bvanassche@acm.org, gost.dev@samsung.com,
	Hui Qi <hui81.qi@samsung.com>,
	Nitesh Shetty <nj.shetty@samsung.com>
Subject: Re: [PATCH v2] nvme: enable FDP support
Date: Mon, 10 Jun 2024 08:52:12 -0600	[thread overview]
Message-ID: <ZmcTHMWb-T78Crfn@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20240610115541.GB19495@lst.de>

On Mon, Jun 10, 2024 at 01:55:41PM +0200, Christoph Hellwig wrote:
> On Mon, Jun 10, 2024 at 07:27:16AM -0400, Martin K. Petersen wrote:
> > > And TP 4146 author list shows 10 companies. Perhaps good enough for 
> > > diverse opinions on how to go about things before settling down.
> > 
> > I think FDP and SCSI streams are less than ideal. 10+ years and the
> > standards bodies still haven't been able to produce an approach that
> > makes sense in the context of a general purpose operating system.
> 
> The SCSI temperature hints are I think exactly what we want.  The fact
> that they had to be shoe horned in in a weird to claim to be streams
> is a little awkward, but sometimes that's need to get things done.

I feel a bit out of the loop here, I'm not sure what the concern is.

I agree the FDP setup is complicated, but none of that is taken on by
the driver. It just discovers the capabilities and maps an arbitrary
software "hint" to an arbitrary device "hint". It's up to the
application to use those optimally; the driver just performs the
requested mapping.

Is it because the names of those hints indicate data lifetime? These are
just arbitrary numbers used by applications to separate placement. If
they were called HINT_A, HINT_B, HINT_C, would that make this ok?


  reply	other threads:[~2024-06-10 14:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240528151007epcas5p32583675f647553923e5ba4987e9bc6ed@epcas5p3.samsung.com>
2024-05-28 15:02 ` [PATCH v2] nvme: enable FDP support Kanchan Joshi
2024-06-07 15:14   ` Keith Busch
2024-06-08  5:17     ` Christoph Hellwig
2024-06-10 10:38       ` Kanchan Joshi
2024-06-10 11:27         ` Martin K. Petersen
2024-06-10 11:53           ` Javier González
2024-06-10 11:55           ` [PATCH v2] " Christoph Hellwig
2024-06-10 14:52             ` Keith Busch [this message]
2024-06-11  5:47               ` Christoph Hellwig
2024-06-11 14:32                 ` Keith Busch
2024-06-11 19:43                   ` Martin K. Petersen
2024-06-11 22:42                     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmcTHMWb-T78Crfn@kbusch-mbp.dhcp.thefacebook.com \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=hui81.qi@samsung.com \
    --cc=javier.gonz@samsung.com \
    --cc=joshi.k@samsung.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=nj.shetty@samsung.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox