From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9290C3064D for ; Mon, 24 Jun 2024 13:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dS1oQIHIHscKh88VbYCDBf5zsHO7alPwC0ZgdKxEDHc=; b=D3Dl3zDJc2+k1QoLT37H4vV822 CEf2yKMQcFeTb4WOfeQvvz4kVg09Lt2XAoGNQXM4zcBw1W7wRdeVTbUHkvXL+4cltA2GQxxdMagLF YnQO9ThJucYxuQKnEYGo0Kh8FiCr6dmBEMqs0cfXf34JjyElwsJIrmED7tIOlVbCjFEBCcbPeaYbA Slq6NDG64kB3+iuHFgYi7t1sBAJnhoDYryWA//CxMgQgyCOQjYCvAFVB1o56IMEff9eb5DkhQftFX U+Q48+Lxi9SljRoQgohATqSOX6znEelwSpslJMxc0odxTyQiH+GZYSB4++0h8sr9KD94NVx85WUJC NEOcVJvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLk1M-0000000Gyp7-3iw9; Mon, 24 Jun 2024 13:46:12 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLk1H-0000000Gyn6-310j; Mon, 24 Jun 2024 13:46:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 511A060346; Mon, 24 Jun 2024 13:46:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C6A4C32782; Mon, 24 Jun 2024 13:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719236766; bh=nEbRkmLliGbrhN7a0dFrrROolzsUWf2ymgDG1frRQgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HPvBUv03t5fHmHl5Vdhl5NNvWh/1rmgJmDIUT78BrhNjkekMyiHBemsXBtITKK+pk Ph9y6SGv/k+x5Jl2xhlIMX2sddEfv5ScOkESPGjMaDvg1ZXM5kaST/YeMPDuDVXpgg iH6h0sucNAo73sjXdAnuoapZ6RfRXTSWnSxyRGyPeNDve4kUinDBuUenLUefA9rCqX 54StG+jluCv5aLHX9mMsHCk5XhZuGMG20N2tbjRRxE9agT2YFzShKRFvN/weyUUZ99 p5MaDhc41zpO0i44wkIP3EtvIWnOiXRYHg0365/uFE0+rIV0Jq+m7pwvM4OmoBjW+O CdaoXjn9E8fNg== Date: Mon, 24 Jun 2024 15:45:57 +0200 From: Niklas Cassel To: Christoph Hellwig Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Jens Axboe , Damien Le Moal , Hannes Reinecke , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [axboe-block:for-next] [block] bd4a633b6f: fsmark.files_per_sec -64.5% regression Message-ID: References: <202406241546.6bbd44a7-oliver.sang@intel.com> <20240624083537.GA19941@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240624083537.GA19941@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_064607_874942_E7F71C3F X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Jun 24, 2024 at 10:35:37AM +0200, Christoph Hellwig wrote: > This is odd to say at least. Any chance you can check the value > of /sys/block/$DEVICE/queue/rotational for the relevant device before > and after this commit? And is this an ATA or NVMe SSD? > Seems to be ATA SSD: https://download.01.org/0day-ci/archive/20240624/202406241546.6bbd44a7-oliver.sang@intel.com/job.yaml ssd_partitions: "/dev/disk/by-id/ata-INTEL_SSDSC2BG012T4_BTHC428201ZX1P2OGN-part1" Most likely btrfs does something different depending on the nonrot flag being set or not. (And like you are suggesting, most likely the value of the nonrot flag is somehow different after commit bd4a633b6f) Kind regards, Niklas