From: Christoph Hellwig <hch@infradead.org>
To: Wang Yugui <wangyugui@e16-tech.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH RFC v2] nvme: basic RMEDIA support for host
Date: Thu, 25 Jul 2024 07:09:30 -0700 [thread overview]
Message-ID: <ZqJcmkVCqKne2R8B@infradead.org> (raw)
In-Reply-To: <20240724123052.49185-1-wangyugui@e16-tech.com>
On Wed, Jul 24, 2024 at 08:30:52PM +0800, Wang Yugui wrote:
> Rotational media(RMEDIA) support is added to the NVMe 2.0 specification.
> We firstly add Rotational media(RMEDIA) support to nvme host, then we can add
> the support to nvme target later if the backstore is a Rotational media(RMEDIA)
> block device.
I'd reword this a bit:
Subject: nvme: add support for the rotational media flag
Add support for the rotational media (RMEDIA) flag in the NVMe 2.0
specification by propagating it to the block layer BLK_FEAT_ROTATIONAL
flag.
> + bool is_rmedia;
I'd stick to the Linux 'rotational' terminology here, i.e.
is_rotational.
> + if(head->rmedia)
missing whitespace after the if here.
But as blk_stack_limits inherits BLK_FEAT_ROTATIONAL I think this
shouldn't even be needed at all.
next prev parent reply other threads:[~2024-07-25 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 23:24 [PATCH RFC] basic RMEDIA support for nvme host Wang Yugui
2024-07-24 12:30 ` [PATCH RFC v2] nvme: basic RMEDIA support for host Wang Yugui
2024-07-25 0:43 ` Damien Le Moal
2024-07-25 1:56 ` Wang Yugui
2024-07-25 14:10 ` Christoph Hellwig
2024-07-25 22:59 ` Damien Le Moal
2024-08-12 14:28 ` Hannes Reinecke
2024-07-25 14:09 ` Christoph Hellwig [this message]
2024-08-06 0:48 ` [PATCH RFC v3] " Wang Yugui
2024-08-06 0:49 ` [PATCH RFC] nvmet: basic RMEDIA support for target Wang Yugui
2024-08-06 8:11 ` Sagi Grimberg
2024-08-06 9:08 ` Wang Yugui
2024-08-06 9:42 ` [PATCH RFC v2] " Wang Yugui
2024-08-06 12:40 ` [PATCH RFC v3] " Wang Yugui
2024-08-07 12:14 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqJcmkVCqKne2R8B@infradead.org \
--to=hch@infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox