From: Niklas Cassel <cassel@kernel.org>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: kamaljit.singh1@wdc.com, dlemoal@kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-rdma: send cntlid in the RDMA_CM_REQUEST Private Data
Date: Mon, 26 Aug 2024 11:27:25 +0200 [thread overview]
Message-ID: <ZsxKfZCxfNfSXzGI@ryzen.lan> (raw)
In-Reply-To: <20240815201131.1439811-2-cassel@kernel.org>
On Thu, Aug 15, 2024 at 10:11:31PM +0200, Niklas Cassel wrote:
> When sending a RDMA_CM_REQUEST, the NVMe RDMA Transport Specification
> allows you to populate the cntlid field in the RDMA_CM_REQUEST Private
> Data.
>
> The cntlid is returned by the target on completion of the first
> RDMA_CM_REQUEST command (which creates the admin queue).
>
> The cntlid field can then be populated by the host when the I/O queues
> are created (using additional RDMA_CM_REQUEST commands), such that the
> target can perform extra validation for additional RDMA_CM_REQUEST
> commands.
>
> This additional error code and error message is also added, such that
> nvme_rdma_cm_msg() will display the proper error message if the target
> fails the RDMA_CM_REQUEST command because of this extra validation.
>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
> drivers/nvme/host/rdma.c | 2 ++
> include/linux/nvme-rdma.h | 6 +++++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
Hello NVMe maintainers,
is there any chance of getting this picked up?
Have a nice day!
Kind regards,
Niklas
next prev parent reply other threads:[~2024-08-26 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 20:11 [PATCH] nvme-rdma: send cntlid in the RDMA_CM_REQUEST Private Data Niklas Cassel
2024-08-16 4:52 ` Christoph Hellwig
2024-08-26 9:27 ` Niklas Cassel [this message]
2024-08-26 10:40 ` Sagi Grimberg
2024-08-26 10:40 ` Sagi Grimberg
2024-08-26 15:15 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsxKfZCxfNfSXzGI@ryzen.lan \
--to=cassel@kernel.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=kamaljit.singh1@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox