Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
	martin.petersen@oracle.com,
	James.Bottomley@hansenpartnership.com, brauner@kernel.org,
	jack@suse.cz, jaegeuk@kernel.org, jlayton@kernel.org,
	chuck.lever@oracle.com, bvanassche@acm.org,
	linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	gost.dev@samsung.com, vishak.g@samsung.com,
	javier.gonz@samsung.com, Nitesh Shetty <nj.shetty@samsung.com>,
	Hui Qi <hui81.qi@samsung.com>
Subject: Re: [PATCH v4 5/5] nvme: enable FDP support
Date: Fri, 6 Sep 2024 10:04:41 -0600	[thread overview]
Message-ID: <ZtsoGX2QY-TjBolb@kbusch-mbp.mynextlight.net> (raw)
In-Reply-To: <20240826170606.255718-6-joshi.k@samsung.com>

On Mon, Aug 26, 2024 at 10:36:06PM +0530, Kanchan Joshi wrote:
> Flexible Data Placement (FDP), as ratified in TP 4146a, allows the host
> to control the placement of logical blocks so as to reduce the SSD WAF.
> 
> Userspace can send the data placement information using the write hints.
> Fetch the placement-identifiers if the device supports FDP.
> 
> The incoming placement hint is mapped to a placement-identifier, which
> in turn is set in the DSPEC field of the write command.
> 
> Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
> Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
> Signed-off-by: Hui Qi <hui81.qi@samsung.com>

I'm still fine with this nvme implementation.

Acked-by: Keith Busch <kbusch@kernel.org>

The reporting via fcntl looks okay to me, but I've never added anything
to that interface, so not sure if there's any problem using it for this.


  reply	other threads:[~2024-09-06 16:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240826171409epcas5p306ba210a9815e202556778a4c105b440@epcas5p3.samsung.com>
2024-08-26 17:06 ` [PATCH v4 0/5] Write-placement hints and FDP Kanchan Joshi
2024-08-26 17:06   ` [PATCH v4 1/5] fs, block: refactor enum rw_hint Kanchan Joshi
2024-08-26 17:44     ` Bart Van Assche
2024-08-27  5:12       ` Kanchan Joshi
2024-08-30 12:17     ` Bart Van Assche
2024-09-02  5:18       ` Kanchan Joshi
2024-08-26 17:06   ` [PATCH v4 2/5] fcntl: rename rw_hint_* to rw_life_hint_* Kanchan Joshi
2024-08-26 17:06   ` [PATCH v4 3/5] fcntl: add F_{SET/GET}_RW_HINT_EX Kanchan Joshi
2024-08-26 17:06   ` [PATCH v4 4/5] sd: limit to use write life hints Kanchan Joshi
2024-08-26 17:06   ` [PATCH v4 5/5] nvme: enable FDP support Kanchan Joshi
2024-09-06 16:04     ` Keith Busch [this message]
2024-09-10  9:25       ` Kanchan Joshi
2024-08-30 11:59   ` [PATCH v4 0/5] Write-placement hints and FDP Javier González
2024-09-03 14:28   ` Kanchan Joshi
2024-09-03 14:35     ` Christian Brauner
2024-09-04 14:57       ` Kanchan Joshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtsoGX2QY-TjBolb@kbusch-mbp.mynextlight.net \
    --to=kbusch@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=chuck.lever@oracle.com \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=hui81.qi@samsung.com \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=javier.gonz@samsung.com \
    --cc=jlayton@kernel.org \
    --cc=joshi.k@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nj.shetty@samsung.com \
    --cc=sagi@grimberg.me \
    --cc=vishak.g@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox