From: Keith Busch <kbusch@kernel.org>
To: gjoyce@linux.ibm.com
Cc: linux-nvme@lists.infradead.org, axboe@fb.com, hch@lst.de,
sagi@grimberg.me, hare@suse.de, dwagner@suse.de,
msuchanek@suse.de, jonathan.derrick@linux.dev,
okozina@redhat.com, nilay@linux.ibm.com
Subject: Re: [PATCH 1/1] nvme: disable CC.CRIME (NVME_CC_CRIME)
Date: Mon, 7 Oct 2024 09:05:44 -0600 [thread overview]
Message-ID: <ZwP4yJXOSTJVLTwX@kbusch-mbp> (raw)
In-Reply-To: <20241007145958.7933-2-gjoyce@linux.ibm.com>
On Mon, Oct 07, 2024 at 09:59:58AM -0500, gjoyce@linux.ibm.com wrote:
> @@ -2458,8 +2458,13 @@ int nvme_enable_ctrl(struct nvme_ctrl *ctrl)
> else
> ctrl->ctrl_config = NVME_CC_CSS_NVM;
>
> - if (ctrl->cap & NVME_CAP_CRMS_CRWMS && ctrl->cap & NVME_CAP_CRMS_CRIMS)
> - ctrl->ctrl_config |= NVME_CC_CRIME;
> + /*
> + * Setting CRIME results in CSTS.RDY before the media is ready. This
> + * make it possible for media related commands to return the error
> + * NVME_SC_ADMIN_COMMAND_MEDIA_NOT_READY. Until the driver is
> + * structured to handle retries, disable CC.CRIME.
> + */
> + ctrl->ctrl_config &= ~NVME_CC_CRIME;
A little further down in this function, there's a check from CC_CRIME to
know which ready timeout value to use. You can remove that check with
this change.
prev parent reply other threads:[~2024-10-07 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 14:59 [PATCH 0/1] nvme: disable CC.CRIME (NVME_CC_CRIME) gjoyce
2024-10-07 14:59 ` [PATCH 1/1] " gjoyce
2024-10-07 15:05 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwP4yJXOSTJVLTwX@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=gjoyce@linux.ibm.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jonathan.derrick@linux.dev \
--cc=linux-nvme@lists.infradead.org \
--cc=msuchanek@suse.de \
--cc=nilay@linux.ibm.com \
--cc=okozina@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox