From: Keith Busch <kbusch@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Abhishek Bapat <abhishekbapat@google.com>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Prashant Malani <pmalani@google.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-sysfs: display max_hw_sectors_kb without requiring namespaces
Date: Tue, 22 Oct 2024 09:51:25 -0600 [thread overview]
Message-ID: <ZxfJ_TfT7MMGWs4X@kbusch-mbp> (raw)
In-Reply-To: <6b00d25e-fe6a-4552-9945-d6181af83137@grimberg.me>
On Tue, Oct 22, 2024 at 06:35:11PM +0300, Sagi Grimberg wrote:
> On 22/10/2024 17:53, Keith Busch wrote:
> > On Thu, Oct 17, 2024 at 02:32:18PM -0700, Abhishek Bapat wrote:
> >
> > The request_queue is owned by the block layer, so that seems like an
> > okay place to export it, but attached to some other device's sysfs
> > directory instead of a gendisk.
> >
> > I'm just suggesting this because it doesn't sound like this is an nvme
> > specific problem.
>
> Won't it be confusing to find queue/ directory in controller nvmeX sysfs
> entry?
It's the attributes of the request queue associated with that
controller, so I think a queue/ directory under it makes sense. That's
how it looks for gendisks, so why not for disk-less queues?
Many queue attributes only make sense for gendisks, though, so maybe
need to tweak visibility if we decide to do it like this.
next prev parent reply other threads:[~2024-10-22 15:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 21:31 [PATCH] nvme-sysfs: display max_hw_sectors_kb without requiring namespaces Abhishek Bapat
2024-10-16 21:54 ` Prashant Malani
2024-10-17 21:09 ` Abhishek Bapat
2024-10-17 16:40 ` Keith Busch
2024-10-17 17:01 ` Caleb Sander
2024-10-17 21:32 ` Abhishek Bapat
2024-10-22 14:53 ` Keith Busch
2024-10-22 15:35 ` Sagi Grimberg
2024-10-22 15:51 ` Keith Busch [this message]
2024-10-23 9:47 ` Sagi Grimberg
2024-10-23 5:24 ` Christoph Hellwig
2024-10-23 9:46 ` Sagi Grimberg
2024-10-18 5:14 ` Christoph Hellwig
2024-10-20 21:25 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxfJ_TfT7MMGWs4X@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=abhishekbapat@google.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pmalani@google.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox