From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Tokunori Ikegami <ikegami.t@gmail.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v4] nvme: change nvme_ns_has_pi() to nvme_ns_supports_pract()
Date: Wed, 23 Oct 2024 07:14:20 -0600 [thread overview]
Message-ID: <Zxj2rPzTGILnrUup@kbusch-mbp> (raw)
In-Reply-To: <ZxjwAsny4yOUHvUD@infradead.org>
On Wed, Oct 23, 2024 at 05:45:54AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 23, 2024 at 07:08:36PM +0900, Tokunori Ikegami wrote:
> > The PI is the first bytes or last bytes of the metadata.
> > So its size is not equal to the metadata size only but below also.
> > Then fix the function to check PI size if metadata size or below.
>
> So basically what the patch does is to make PRACT work for PI where
> the metadata size is bigger than the PI tuple size, right? Maybe state
> that clearly and put less emphasis on the mechanics of the change.
You can't just have a patch declare that PRACT works this way. The spec
says it only works if ms == PI tuple size, otherwise it doesn't do
anything.
next prev parent reply other threads:[~2024-10-23 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 10:08 [PATCH v4] nvme: change nvme_ns_has_pi() to nvme_ns_supports_pract() Tokunori Ikegami
2024-10-23 12:45 ` Christoph Hellwig
2024-10-23 13:14 ` Keith Busch [this message]
2024-10-23 13:19 ` Christoph Hellwig
2024-10-23 13:21 ` Keith Busch
2024-10-23 14:44 ` Tokunori Ikegami
2024-10-23 15:11 ` Keith Busch
2024-10-23 16:33 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxj2rPzTGILnrUup@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@infradead.org \
--cc=ikegami.t@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox