Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jianchao.w.wang@oracle.com (jianchao.wang)
Subject: [PATCH] nvme-pci: ensure nvme_timeout complete before initializing procedure
Date: Tue, 23 Jan 2018 09:43:04 +0800	[thread overview]
Message-ID: <a3fc1646-37cc-7c15-0085-35a320d0a3b8@oracle.com> (raw)
In-Reply-To: <20180122215436.GS12043@localhost.localdomain>

Hi Christoph and Keith

Really sorry for this.

On 01/23/2018 05:54 AM, Keith Busch wrote:
> On Mon, Jan 22, 2018@09:14:23PM +0100, Christoph Hellwig wrote:
>>> Link: https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2018_1_19_68&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=7WdAxUBeiTUTCy8v-7zXyr4qk7sx26ATvfo6QSTvZyQ&m=xJVh7u7o8UBQko2JJRmxqldiuMhaIosNJN8WTkhAF98&s=uk1TvCGpW928A4GMJh1tvxNvPiVfgJvFjjPn69f8fNA&e=
>>> Suggested-by: Keith Busch <keith.busch at intel.com>
>>> Signed-off-by: Keith Busch <keith.busch at intel.com>
>>> Signed-off-by: Jianchao Wang <jianchao.w.wang at oracle.com>
>>
>> Why does this have a signoff from Keith?
> 
The the nvme_sync_queues is from Keith in the mail thread, so I added this.
I will discard it and just reserve "suggested-by" later.

> Right, I hadn't signed off that. I just trying to get feeback if
> someting like that was closing the theoretical gap, which it does.

Yes.

> 
> I actually have something similar in my patch queue I was about to send
> around this area, though. I don't like having the IO path take on the
> error handling, and I think ending unstarted requests directly will be
> better long term.
Yes.

Many thanks for your kindly response.


Thanks
Jianchao

      reply	other threads:[~2018-01-23  1:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22  7:53 [PATCH] nvme-pci: ensure nvme_timeout complete before initializing procedure Jianchao Wang
2018-01-22 20:14 ` Christoph Hellwig
2018-01-22 21:54   ` Keith Busch
2018-01-23  1:43     ` jianchao.wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3fc1646-37cc-7c15-0085-35a320d0a3b8@oracle.com \
    --to=jianchao.w.wang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox