From: james.smart@broadcom.com (James Smart)
Subject: [PATCH 1/3] nvme-fabrics: refactor queue ready check
Date: Thu, 14 Jun 2018 10:37:14 -0700 [thread overview]
Message-ID: <a7065ad6-6438-b4a7-c3cf-dd7a90b0d092@broadcom.com> (raw)
In-Reply-To: <20180614122215.4395-2-hch@lst.de>
On 6/14/2018 5:22 AM, Christoph Hellwig wrote:
> Move the is_connected check to the fibre channel transport, as it has no
> meaning for other transports. To facilitate this split out a new
> nvmf_fail_nonready_command helper that is called by the transport when
> it is asked to handle a command on a queue that is not ready.
>
> Also avoid a function call for the queue live fast path by inlining
> the check.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
> drivers/nvme/host/fabrics.c | 59 +++++++++++++++----------------------
> drivers/nvme/host/fabrics.h | 13 ++++++--
> drivers/nvme/host/fc.c | 9 +++---
> drivers/nvme/host/rdma.c | 7 ++---
> drivers/nvme/target/loop.c | 7 ++---
> 5 files changed, 45 insertions(+), 50 deletions(-)
>
>
looks good
Reviewed-by:? James Smart?? <james.smart at broadcom.com>
next prev parent reply other threads:[~2018-06-14 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 12:22 queue ready fixes and cleanups v2 Christoph Hellwig
2018-06-14 12:22 ` [PATCH 1/3] nvme-fabrics: refactor queue ready check Christoph Hellwig
2018-06-14 17:37 ` James Smart [this message]
2018-06-14 12:22 ` [PATCH 2/3] nvme-fabrics: handle the admin-only case properly in nvmf_check_ready Christoph Hellwig
2018-06-14 12:22 ` [PATCH 3/3] nvme-fabrics: fix and refine state checks in __nvmf_check_ready Christoph Hellwig
2018-06-14 17:37 ` James Smart
2018-06-15 9:32 ` Christoph Hellwig
2018-06-15 14:18 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7065ad6-6438-b4a7-c3cf-dd7a90b0d092@broadcom.com \
--to=james.smart@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox