From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>, Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-nvme@lists.infradead.org, Amit.Engel@Dell.com, kbusch@kernel.org
Subject: Re: [PATCH] nvme: print disposition on err req completion
Date: Wed, 7 Jun 2023 18:08:16 +0300 [thread overview]
Message-ID: <a8f3f9eb-7267-219e-f6cc-f36c0ca56080@grimberg.me> (raw)
In-Reply-To: <20230607050059.GA19879@lst.de>
>> Currently we don't print disposition in the request completion path
>> in nvme_complete_rq() tracepoint, so when request fails it is not
>> straight forward to understand the diposition making it hard to debug
>> the problems in the field.
>>
>> Update nvme_complete_rq() tracepoint to print the disposition when
>> request fails, since disposition value will always be 0 when request
>> status = 0.
>
> Hmm, not sure this is the right way to approach it. I'd rather
> redo how the trace points work by having a class and the ondividual
> tracepoints in nvme_end_req/nvme_retry_req/nvme_failover_req.
:)
This was the original proposal (posted as a question to the list),
and I proposed this approach. You don't like it?
I kinda like the explicit disposition output.
next prev parent reply other threads:[~2023-06-07 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 6:49 [PATCH] nvme: print disposition on err req completion Chaitanya Kulkarni
2023-06-05 22:32 ` Sagi Grimberg
2023-06-07 5:00 ` Christoph Hellwig
2023-06-07 15:08 ` Sagi Grimberg [this message]
2023-06-07 17:06 ` Engel, Amit
2023-06-07 23:31 ` Chaitanya Kulkarni
2023-06-08 5:53 ` Christoph Hellwig
2023-06-08 7:02 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8f3f9eb-7267-219e-f6cc-f36c0ca56080@grimberg.me \
--to=sagi@grimberg.me \
--cc=Amit.Engel@Dell.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).