From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 1/2] IB/mlx5: posting klm/mtt list inline in the send queue for reg_wr
Date: Sun, 29 Oct 2017 19:09:24 +0200 [thread overview]
Message-ID: <a97dd33b-1185-b2db-6df2-a636be963c71@grimberg.me> (raw)
In-Reply-To: <1509295101-14081-2-git-send-email-idanb@mellanox.com>
> As most kernel RDMA ULPs, NVMe over Fabrics in its secure
> "register_always" mode registers and invalidates user buffer
> upon each IO.
Again, lets drop the secured mode language.
> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> index acb79d3..b25b93d 100644
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -53,6 +53,7 @@ enum {
>
> enum {
> MLX5_IB_SQ_STRIDE = 6,
> + MLX5_IB_SQ_UMR_INLINE_THRESHOLD = 64,
> };
Is this a device capability? Is it true for all mlx5 devices?
can we get it from the FW instead?
Otherwise, looks good to me,
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
next prev parent reply other threads:[~2017-10-29 17:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 16:38 [PATCH 0/2] Performance Improvents for Secured Mode NVMe over Fabrics and other RDMA ULPs idanb
2017-10-29 16:38 ` [PATCH 1/2] IB/mlx5: posting klm/mtt list inline in the send queue for reg_wr idanb
2017-10-29 17:09 ` Sagi Grimberg [this message]
2018-04-19 21:11 ` roland
2018-04-20 2:04 ` Doug Ledford
2018-04-20 19:07 ` Max Gurtovoy
2017-10-29 16:38 ` [PATCH 2/2] nvme-rdma: Add remote_invalidation module parameter idanb
2017-10-29 17:52 ` Jason Gunthorpe
2017-10-30 8:14 ` Sagi Grimberg
2017-10-30 8:38 ` idanb
2017-10-30 9:44 ` Sagi Grimberg
2017-10-30 10:31 ` idanb
2017-10-30 10:33 ` Sagi Grimberg
2017-10-30 12:35 ` idanb
2017-10-29 18:24 ` Chuck Lever
2017-10-30 18:18 ` Chuck Lever
2017-10-30 8:11 ` Sagi Grimberg
2017-10-30 8:45 ` idanb
2017-10-29 16:59 ` [PATCH 0/2] Performance Improvents for Secured Mode NVMe over Fabrics and other RDMA ULPs Sagi Grimberg
2017-10-29 17:09 ` Max Gurtovoy
2017-10-29 17:43 ` Leon Romanovsky
[not found] ` <AM0PR0502MB38906F57CD68C3707F8FE765C5580@AM0PR0502MB3890.eurprd05.prod.outlook.com>
2017-10-30 5:21 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a97dd33b-1185-b2db-6df2-a636be963c71@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).