From: Keith Busch <kbusch@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Kanchan Joshi <joshi.k@samsung.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] nvme/pci: PRP list DMA pool partitioning
Date: Tue, 22 Apr 2025 16:46:05 -0600 [thread overview]
Message-ID: <aAgcLf-X_kWTPRGZ@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <CADUfDZr5nq9fAvxSZJwUmuZKry6pHqLrucLtJLmV8cAvZ6O6eg@mail.gmail.com>
On Tue, Apr 22, 2025 at 03:04:37PM -0700, Caleb Sander Mateos wrote:
> On Tue, Apr 22, 2025 at 10:48 AM Keith Busch <kbusch@kernel.org> wrote:
> >
> > On Tue, Apr 22, 2025 at 10:19:57AM -0600, Caleb Sander Mateos wrote:
> > > This reduces the _raw_spin_lock_irqsave overhead by about half, to
> > > 1.2%.
> >
> > Could you try this atop your series? I hope to see if we can squeeze a
> > little more out by keeping the spinlock and list links local to the node
> > using them.
>
> That does help save some CPU time in dma_pool_alloc too. It's down
> from 0.87% of CPU time to 0.52% while doing 5% more IOPS. I'll include
> your patch (with a few tweaks) in a v5 of this series. Hopefully
> you're okay if I include your Signed-off-by.
Awesome! And yes, totally okay with me to fold the patch into your
series.
prev parent reply other threads:[~2025-04-22 22:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 16:19 [PATCH v4 0/2] nvme/pci: PRP list DMA pool partitioning Caleb Sander Mateos
2025-04-22 16:19 ` [PATCH v4 1/2] nvme/pci: factor out nvme_init_hctx() helper Caleb Sander Mateos
2025-04-22 16:28 ` Keith Busch
2025-04-22 16:19 ` [PATCH v4 2/2] nvme/pci: make PRP list DMA pools per-NUMA-node Caleb Sander Mateos
2025-04-22 16:34 ` Keith Busch
2025-04-22 17:48 ` [PATCH v4 0/2] nvme/pci: PRP list DMA pool partitioning Keith Busch
2025-04-22 22:04 ` Caleb Sander Mateos
2025-04-22 22:46 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAgcLf-X_kWTPRGZ@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox