Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Jeffrey Lien <Jeff.Lien@sandisk.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Avinash M N <Avinash.M.N@sandisk.com>
Subject: Re: NVMe CLI Invalid PRP Entry Status Failures
Date: Thu, 15 May 2025 08:18:09 -0600	[thread overview]
Message-ID: <aCX3offAfe1k0_KE@kbusch-mbp> (raw)
In-Reply-To: <MW3PR16MB38975C2057D1EF440FBD60B0F390A@MW3PR16MB3897.namprd16.prod.outlook.com>

On Thu, May 15, 2025 at 02:01:50PM +0000, Jeffrey Lien wrote:
> 
> We are seeing invalid PRP entry status failures with transfer lengths
> 0x2000 on nvme cli admin-passthru commands.  This started happening on
> the 6.10 linux kernel version and the commands were working on kernels
> <= to the 5.15 version.   See example commands below.   I didn't find
> any obvious commits in that time frame that might be causing these
> failures.  Does anyone have any insight to any of the changes that
> might be causing these errors?
> 
> Example command: sudo nvme admin-passthru /dev/nvme0 --opcode=0xD2 --cdw10=0x12600 --cdw12=0x00010132 -l 0x2000 -r -b
>  
> .	Initially any transfer length > 0x2000 fails in invalid PRP entry status
> $ sudo nvme admin-passthru /dev/nvme0 --opcode=0xD2 --cdw10=0x12600 --cdw12=0x00010132 -l 0x2000 -r -b Admin Command Vendor Specific is Success and result: 0x00000000

The only thing that comes to mind is that we allow dword aligned buffers
now. The driver used to require 4k aligned, but nvme spec doesn't
require that. My guess is your device is incorrectly rejecting admin
commands that have a dword offset in PRP1. Do you have any visibility
into the device's reasoning for this response here?


  reply	other threads:[~2025-05-15 14:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <MW3PR16MB3897F0E659B34877C4D5197CF391A@MW3PR16MB3897.namprd16.prod.outlook.com>
2025-05-15 14:01 ` NVMe CLI Invalid PRP Entry Status Failures Jeffrey Lien
2025-05-15 14:18   ` Keith Busch [this message]
     [not found]     ` <LV3PR16MB606775F391112B2DADF64463B590A@LV3PR16MB6067.namprd16.prod.outlook.com>
2025-05-16 12:33       ` Keith Busch
     [not found]         ` <LV3PR16MB6067E928D739DCB65F31FE46B593A@LV3PR16MB6067.namprd16.prod.outlook.com>
2025-05-16 14:41           ` Keith Busch
2025-05-24  4:22             ` Avinash M N
2025-05-24 14:26               ` Keith Busch
2025-05-26  7:09                 ` Christoph Hellwig
2025-05-27 15:44                   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCX3offAfe1k0_KE@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=Avinash.M.N@sandisk.com \
    --cc=Jeff.Lien@sandisk.com \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox