From: Keith Busch <kbusch@kernel.org>
To: John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, alan.adamson@oracle.com
Subject: Re: [PATCH] nvme: fix endianness of command word prints in nvme_log_err_passthru()
Date: Mon, 30 Jun 2025 10:44:11 -0600 [thread overview]
Message-ID: <aGK-28n4bhw7EVAr@kbusch-mbp> (raw)
In-Reply-To: <20250630162153.4040149-1-john.g.garry@oracle.com>
On Mon, Jun 30, 2025 at 04:21:53PM +0000, John Garry wrote:
> The command word members of struct nvme_common_command are __le32 type,
> so use helper le32_to_cpu() to read them properly.
Looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2025-06-30 17:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 16:21 [PATCH] nvme: fix endianness of command word prints in nvme_log_err_passthru() John Garry
2025-06-30 16:44 ` Keith Busch [this message]
2025-07-01 15:51 ` alan.adamson
2025-07-03 11:45 ` Christoph Hellwig
2025-07-03 11:48 ` John Garry
2025-07-14 13:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGK-28n4bhw7EVAr@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=alan.adamson@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox