[PATCH] nvme: fix endianness of command word prints in nvme_log_err_passthru()

[PATCH] nvme: fix endianness of command word prints in nvme_log_err_passthru()

[John Garry]

The command word members of struct nvme_common_command are __le32 type,
so use helper le32_to_cpu() to read them properly.

Fixes: 9f079dda1433 ("nvme: allow passthru cmd error logging")
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
build tested only

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 7493e5aa984c..551595c18791 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -381,12 +381,12 @@ static void nvme_log_err_passthru(struct request *req)
 		nr->status & NVME_SC_MASK,	/* Status Code */
 		nr->status & NVME_STATUS_MORE ? "MORE " : "",
 		nr->status & NVME_STATUS_DNR  ? "DNR "  : "",
-		nr->cmd->common.cdw10,
-		nr->cmd->common.cdw11,
-		nr->cmd->common.cdw12,
-		nr->cmd->common.cdw13,
-		nr->cmd->common.cdw14,
-		nr->cmd->common.cdw15);
+		le32_to_cpu(nr->cmd->common.cdw10),
+		le32_to_cpu(nr->cmd->common.cdw11),
+		le32_to_cpu(nr->cmd->common.cdw12),
+		le32_to_cpu(nr->cmd->common.cdw13),
+		le32_to_cpu(nr->cmd->common.cdw14),
+		le32_to_cpu(nr->cmd->common.cdw15));
 }
 
 enum nvme_disposition {
-- 
2.43.5

Re: [PATCH] nvme: fix endianness of command word prints in nvme_log_err_passthru()

[Keith Busch]

On Mon, Jun 30, 2025 at 04:21:53PM +0000, John Garry wrote:
> The command word members of struct nvme_common_command are __le32 type,
> so use helper le32_to_cpu() to read them properly.

Looks good.

Reviewed-by: Keith Busch <kbusch@kernel.org>

Re: [PATCH] nvme: fix endianness of command word prints in nvme_log_err_passthru()

[alan.adamson]

On 6/30/25 9:21 AM, John Garry wrote:
> The command word members of struct nvme_common_command are __le32 type,
> so use helper le32_to_cpu() to read them properly.
>
> Fixes: 9f079dda1433 ("nvme: allow passthru cmd error logging")
> Signed-off-by: John Garry <john.g.garry@oracle.com>

Reviewed-by: Alan Adamson <alan.adamson@oracle.com>



> ---
> build tested only
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 7493e5aa984c..551595c18791 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -381,12 +381,12 @@ static void nvme_log_err_passthru(struct request *req)
>   		nr->status & NVME_SC_MASK,	/* Status Code */
>   		nr->status & NVME_STATUS_MORE ? "MORE " : "",
>   		nr->status & NVME_STATUS_DNR  ? "DNR "  : "",
> -		nr->cmd->common.cdw10,
> -		nr->cmd->common.cdw11,
> -		nr->cmd->common.cdw12,
> -		nr->cmd->common.cdw13,
> -		nr->cmd->common.cdw14,
> -		nr->cmd->common.cdw15);
> +		le32_to_cpu(nr->cmd->common.cdw10),
> +		le32_to_cpu(nr->cmd->common.cdw11),
> +		le32_to_cpu(nr->cmd->common.cdw12),
> +		le32_to_cpu(nr->cmd->common.cdw13),
> +		le32_to_cpu(nr->cmd->common.cdw14),
> +		le32_to_cpu(nr->cmd->common.cdw15));
>   }
>   
>   enum nvme_disposition {

Re: [PATCH] nvme: fix endianness of command word prints in nvme_log_err_passthru()

[Christoph Hellwig]

I tried to apply this to nvme-6.17, but it depend on the previous
cdw numbering fix in 6.16.  I guess we'll want to pick this up after
6.17-rc1 unless there's a need to rush it into 6.16.

Re: [PATCH] nvme: fix endianness of command word prints in nvme_log_err_passthru()

[John Garry]

On 03/07/2025 12:45, Christoph Hellwig wrote:
> I tried to apply this to nvme-6.17, but it depend on the previous
> cdw numbering fix in 6.16.  I guess we'll want to pick this up after
> 6.17-rc1 unless there's a need to rush it into 6.16.
> 

I don't think it's realy necessary for 6.16 .  I just noticed this issue 
when reviewing that cdw numbering fix (so not affecting me).

Re: [PATCH] nvme: fix endianness of command word prints in nvme_log_err_passthru()

[Christoph Hellwig]

I ended up applying this to nvme-6.16 - it is a trivial fix for a
tracing path and waiting out of past 6.17-rc1 just increases the
chances it will get lost.