From: Niklas Cassel <cassel@kernel.org>
To: Kamaljit Singh <kamaljit.singh1@wdc.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
dlemoal@kernel.org
Subject: Re: [PATCH v3 1/2] nvme: add capability to connect to an administrative controller
Date: Fri, 18 Jul 2025 10:15:18 +0200 [thread overview]
Message-ID: <aHoClrMYgaZwzfeL@ryzen> (raw)
In-Reply-To: <20250718001415.3774178-2-kamaljit.singh1@wdc.com>
Hello Kamaljit,
I think that the patch looks good.
That said, the Suggested-by trailer should go together with all other
trailers at the end of the commit log, see e.g.:
https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/commit/?id=a4daf088a77323154514eb1f8626bbdf9329cfd4
Kind regards,
Niklas
next prev parent reply other threads:[~2025-07-18 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 0:14 [PATCH v3 0/2] Support for Administrative Controllers Kamaljit Singh
2025-07-18 0:14 ` [PATCH v3 1/2] nvme: add capability to connect to an administrative controller Kamaljit Singh
2025-07-18 4:14 ` Damien Le Moal
2025-07-18 8:15 ` Niklas Cassel [this message]
2025-07-22 7:06 ` Hannes Reinecke
2025-07-22 17:34 ` Kamaljit Singh
2025-07-23 6:10 ` hch
2025-07-18 0:14 ` [PATCH v3 2/2] nvme: prevent admin controller from smart log fetch (LID 2) Kamaljit Singh
2025-07-18 4:17 ` Damien Le Moal
2025-07-22 7:07 ` Hannes Reinecke
2025-07-22 20:57 ` Kamaljit Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHoClrMYgaZwzfeL@ryzen \
--to=cassel@kernel.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=kamaljit.singh1@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox