From: Chris Leech <cleech@redhat.com>
To: linux-nvme@lists.infradead.org
Cc: Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>,
John Meneghini <jmeneghi@redhat.com>
Subject: Re: [PATCH 0/1] NVMe/TLS connection issues to SPDK
Date: Tue, 12 Aug 2025 15:05:50 -0700 [thread overview]
Message-ID: <aJu6viaKxh4CX4Hh@my-developer-toolbox-latest> (raw)
In-Reply-To: <20250721021718.1159879-1-cleech@redhat.com>
On Sun, Jul 20, 2025 at 07:17:17PM -0700, Chris Leech wrote:
> I was attempting to debug connecting the Linux driver / libnvme /
> ktls-utils host stack to the SPDK nvmf_tgt over TLS, and ran into some
> issues.
>
> The TLS connection fails to complete a handshake because the TLS PSKs
> are different. The NVMe/TCP specified key derivation steps from the
> configured interchange format, to a retained PSK and finally the TLS
> PSK, is implemented incompatibly in libnvme and SPDK. After some
> investigation, I believe the SPDK implementation to be correct and am
> providing a libnvme patch to match it. With libnvme modified, I see the
> TLS handshake complete in tlshd.
Ug, the kernel has key derivation code for secure channel concatenation
and it has the same issue.
RFC patchs to follow, only tested with a quick blktests nvme/063
currently.
- Chris
next prev parent reply other threads:[~2025-08-12 22:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 2:17 [PATCH 0/1] NVMe/TLS connection issues to SPDK Chris Leech
2025-07-21 2:17 ` [PATCH 1/1] libnvme: TLS PSK derivation fixes Chris Leech
2025-07-21 6:36 ` Hannes Reinecke
2025-07-21 15:31 ` Chris Leech
2025-07-25 9:36 ` Hannes Reinecke
2025-07-25 18:08 ` Chris Leech
2025-07-28 7:12 ` Hannes Reinecke
2025-08-08 16:18 ` John Meneghini
2025-08-12 4:33 ` Chris Leech
2025-08-18 9:42 ` Hannes Reinecke
2025-08-20 8:10 ` Daniel Wagner
2025-08-20 8:22 ` Hannes Reinecke
2025-08-26 14:09 ` John Meneghini
2025-07-21 7:11 ` [PATCH 0/1] NVMe/TLS connection issues to SPDK Hannes Reinecke
2025-07-21 15:44 ` Chris Leech
2025-07-22 6:27 ` Hannes Reinecke
2025-07-24 14:35 ` Daniel Wagner
2025-07-24 15:07 ` Chris Leech
2025-07-24 15:37 ` Daniel Wagner
2025-08-12 22:05 ` Chris Leech [this message]
2025-08-12 22:11 ` [RFC PATCH 1/2] crypto: hkdf: add hkdf_expand_label() Chris Leech
2025-08-18 9:44 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJu6viaKxh4CX4Hh@my-developer-toolbox-latest \
--to=cleech@redhat.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=jmeneghi@redhat.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox