From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F04E1CA0FE7 for ; Tue, 26 Aug 2025 14:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TcDUP+ps63/jrGgAjCJp4o8llbkXnQ4nl0SzsfkEYiU=; b=ymTqC3/AFhBPvHy6cMg5p/xH9w 3vNCTHkEan6h0Ar/R87eVFxedA7EDkUWSugduL90BVzrZlc0Z89gZ5C1CDWNaQA3YzceJzfhEcuCY NMY5BesqXCjfgByc8ToR7pgSP8I2+71sDUy1IntaQtSsm8lD1SLCVYvaosBQF3HJTtId+bWHQAqew 8lJ0g3/p3qLbR7DWoh+5PtOfnS5QAQl/Z4ujT/jSBjljcyWyc2jtnW1Gylb3yITZV2ZtWsA0Lr9N+ Ac0zUDzINczkYa+QJ5Y0Cs1nBPGsK1gy37RJb9wVC69i29H1qPEpmuVi2jGXpesXB+8SxdL0e/4Kv BLQuSK1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqv6X-0000000CLfb-0uKZ; Tue, 26 Aug 2025 14:56:57 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uquzE-0000000CKEp-0tJH for linux-nvme@lists.infradead.org; Tue, 26 Aug 2025 14:49:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756219763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TcDUP+ps63/jrGgAjCJp4o8llbkXnQ4nl0SzsfkEYiU=; b=frcsbHVrPvR8BoLlOE14Ju/Pg8YHbn1EU84LcFDZYLDHDVEDrtS+slqjDcDsN7kH3EfD1s foi/0dMPXpm7xW7ipbAYybHYb4+hrU//N49WAJlW/83keF5hi/z4g+tiDR4qttolEtPN36 TB1N8DpFcltbrAqfVrOPupA9ZtSFlYk= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-q2KcS3WcN--6jbbez6fBkA-1; Tue, 26 Aug 2025 10:49:19 -0400 X-MC-Unique: q2KcS3WcN--6jbbez6fBkA-1 X-Mimecast-MFC-AGG-ID: q2KcS3WcN--6jbbez6fBkA_1756219758 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 30CD019560AD; Tue, 26 Aug 2025 14:49:18 +0000 (UTC) Received: from fedora (unknown [10.72.116.57]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BEB65180028A; Tue, 26 Aug 2025 14:49:13 +0000 (UTC) Date: Tue, 26 Aug 2025 22:49:07 +0800 From: Ming Lei To: Nilay Shroff Cc: Venkat Rao Bagalkote , LKML , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org Subject: Re: [blktest/nvme/058] Kernel OOPs while running nvme/058 tests Message-ID: References: <3a07b752-06a4-4eee-b302-f4669feb859d@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250826_074924_320913_9FE36E74 X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Aug 26, 2025 at 03:26:02PM +0530, Nilay Shroff wrote: > > > On 8/26/25 2:38 PM, Ming Lei wrote: > > On Tue, Aug 26, 2025 at 02:00:56PM +0530, Venkat Rao Bagalkote wrote: > >> Greetings!!! > >> > >> > >> IBM CI has reported a kernel OOPs, while running blktest suite(nvme/058 > >> test). > >> > >> > >> Kernel Repo: > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > >> > >> > >> Traces: > >> > >> > >> [37496.800225] BUG: Kernel NULL pointer dereference at 0x00000000 > >> [37496.800230] Faulting instruction address: 0xc0000000008a34b0 > >> [37496.800235] Oops: Kernel access of bad area, sig: 11 [#1] > > > > ... > > > >> [37496.800365] GPR28: 0000000000000001 0000000000000001 c0000000b005c400 > >> 0000000000000000 > >> [37496.800424] NIP [c0000000008a34b0] __rq_qos_done_bio+0x3c/0x88 > > > > It looks regression from 370ac285f23a ("block: avoid cpu_hotplug_lock depedency on freeze_lock"), > > For nvme mpath, same bio crosses two drivers, so QUEUE_FLAG_QOS_ENABLED & q->rq_qos check can't > > be skipped. > > > Thanks Ming for looking at it. And yes you were correct, we can't skip > QUEUE_FLAG_QOS_ENABLED & q->rq_qos for NVMe, However this issue only > manifests with NVMe multipath enabled, as that would create the stacked > NVMe devices. So shall I send the fix or are you going to send the patch > with fix? Yeah, please go ahead and prepare the fix. Thanks, Ming