Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	hch@lst.de, axboe@kernel.dk, martin.petersen@oracle.com,
	jgg@nvidia.com, leon@kernel.org
Subject: Re: [PATCH 2/2] blk-mq-dma: bring back p2p request flags
Date: Fri, 29 Aug 2025 09:15:50 -0600	[thread overview]
Message-ID: <aLHEJnKgVGYdnb08@kbusch-mbp> (raw)
In-Reply-To: <20250829142307.3769873-3-kbusch@meta.com>

On Fri, Aug 29, 2025 at 07:23:07AM -0700, Keith Busch wrote:
> @@ -252,7 +252,7 @@ static unsigned int bvec_from_pages(struct bio_vec *bvec, struct page **pages,
>  			bytes -= next;
>  		}
>  
> -		if (is_pci_p2pdma_page(page))
> +		if (is_pci_p2pdma_page(pages[i]))
>  			*is_p2p = true;

Oh no... >_<

This part should have been folded into patch 1.


  reply	other threads:[~2025-08-29 18:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 14:23 [PATCH 0/2] blk-mq-dma: p2p cleanups and integrity fixup Keith Busch
2025-08-29 14:23 ` [PATCH 1/2] blk-integrity: enable p2p source and destination Keith Busch
2025-09-02  5:27   ` Christoph Hellwig
2025-08-29 14:23 ` [PATCH 2/2] blk-mq-dma: bring back p2p request flags Keith Busch
2025-08-29 15:15   ` Keith Busch [this message]
2025-09-02  5:33   ` Christoph Hellwig
2025-09-02 14:36     ` Keith Busch
2025-09-02 14:54       ` Christoph Hellwig
2025-09-02 14:57       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLHEJnKgVGYdnb08@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jgg@nvidia.com \
    --cc=kbusch@meta.com \
    --cc=leon@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox