From: Christoph Hellwig <hch@infradead.org>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Sagi Grimberg <sagi@grimberg.me>, Yi Zhang <yi.zhang@redhat.com>
Subject: Re: [PATCH] nvme-multipath: fix lockdep WARN due to partition scan work
Date: Wed, 22 Oct 2025 22:54:54 -0700 [thread overview]
Message-ID: <aPnDLr2IiOQUQLKI@infradead.org> (raw)
In-Reply-To: <20251023001937.218014-1-shinichiro.kawasaki@wdc.com>
On Thu, Oct 23, 2025 at 09:19:37AM +0900, Shin'ichiro Kawasaki wrote:
> Blktests test cases nvme/014, 057 and 058 fail occasionally due to a
> lockdep WARN. As reported in the Closes tag URL, the WARN indicates that
> a deadlock can happen due to the dependency among disk->open_mutex,
> kblockd workqueue completion and partition_scan_work completion.
>
> To avoid the lockdep WARN and the potential deadlock, cut the dependency
> by running the partition_scan_work not by kblockd workqueue but by
> nvme_wq.
The partition_scan_work was added in 1f021341eef4 ("nvme-multipath:
defer partition scanning") to get it out of the scan work to avoid
deadlocks. I suspect moving it to the same workqueue might reintroduce
the deadlocks, so we might have to add a new workqueue here. Keith
might remember more.
next prev parent reply other threads:[~2025-10-23 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 0:19 [PATCH] nvme-multipath: fix lockdep WARN due to partition scan work Shin'ichiro Kawasaki
2025-10-23 5:54 ` Christoph Hellwig [this message]
2025-10-23 14:28 ` Keith Busch
2025-10-28 7:55 ` Shinichiro Kawasaki
2025-10-29 7:54 ` hch
2025-11-05 7:32 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPnDLr2IiOQUQLKI@infradead.org \
--to=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox