From: Keith Busch <kbusch@kernel.org>
To: Casey Chen <cachen@purestorage.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, hch@lst.de, ming.lei@redhat.com,
chaitanyak@nvidia.com
Subject: Re: [PATCH] nvme: fix admin request_queue lifetime
Date: Wed, 5 Nov 2025 13:31:10 -0700 [thread overview]
Message-ID: <aQu0Dqc6L17WplVt@kbusch-mbp> (raw)
In-Reply-To: <CALCePG1FFQUWg2u-RhY4DQ9uVxd3uMuwSdvyU-r-ssm_dQjY=Q@mail.gmail.com>
On Wed, Nov 05, 2025 at 12:21:14PM -0800, Casey Chen wrote:
> On Tue, Nov 4, 2025 at 3:00 PM Keith Busch <kbusch@meta.com> wrote:
> > @@ -5045,6 +5044,7 @@ static void nvme_free_ctrl(struct device *dev)
> > container_of(dev, struct nvme_ctrl, ctrl_device);
> > struct nvme_subsystem *subsys = ctrl->subsys;
> >
> > + blk_put_queue(ctrl->admin_q);
>
> Wait. Do we need to check ctrl->admin_q non-NULL before putting it ?
> If nvme_alloc_admin_tag_set() fails, blk_put_queue() would put NULL
> and panic kernel.
Oh, like if we call nvme_uninit_ctrl() prior to allocating the tagset?
Yes, I think you're right, unlikely as that is to occur. Thanks, I'll
fold in your suggestion.
next prev parent reply other threads:[~2025-11-05 20:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 22:59 [PATCH] nvme: fix admin request_queue lifetime Keith Busch
2025-11-04 23:08 ` Chaitanya Kulkarni
2025-11-04 23:22 ` Casey Chen
2025-11-05 1:20 ` Ming Lei
2025-11-05 7:38 ` Hannes Reinecke
2025-11-05 13:14 ` Christoph Hellwig
2025-11-05 20:21 ` Casey Chen
2025-11-05 20:31 ` Keith Busch [this message]
2025-11-06 0:10 ` Chaitanya Kulkarni
2025-11-05 21:31 ` Ewan Milne
2025-11-05 22:34 ` Keith Busch
2025-11-06 19:33 ` Ewan Milne
2025-11-30 23:16 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQu0Dqc6L17WplVt@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=cachen@purestorage.com \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox