From: Keith Busch <kbusch@kernel.org>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
sagi@grimberg.me, hare@suse.de, dwagner@suse.de,
wenxiong@linux.ibm.com, gjoyce@ibm.com
Subject: Re: [PATCH 1/7] nvme: export command retry count via sysfs
Date: Fri, 30 Jan 2026 13:33:05 -0700 [thread overview]
Message-ID: <aX0VgduYJckUaZ3O@kbusch-mbp> (raw)
In-Reply-To: <20260130182028.885089-2-nilay@linux.ibm.com>
On Fri, Jan 30, 2026 at 11:50:18PM +0530, Nilay Shroff wrote:
> nvme_req(req)->retries++;
> + if (ns)
> + ns->retries++;
> + else
> + nvme_req(req)->ctrl->retries++;
I don't think admin commands ever retry with this driver, so probably
not worth tracking it.
And as unlikely as it is to happen, might want to ensure it doesn't
wrap back to zero. The size_add() function handles that.
next prev parent reply other threads:[~2026-01-30 20:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 18:20 [PATCH 0/7] nvme: export additional diagnostic counters via sysfs Nilay Shroff
2026-01-30 18:20 ` [PATCH 1/7] nvme: export command retry count " Nilay Shroff
2026-01-30 20:33 ` Keith Busch [this message]
2026-02-02 13:33 ` Nilay Shroff
2026-01-30 18:20 ` [PATCH 2/7] nvme: export multipath failover " Nilay Shroff
2026-01-30 18:20 ` [PATCH 3/7] nvme: export command error counters " Nilay Shroff
2026-01-30 18:20 ` [PATCH 4/7] nvme: export I/O requeue count when no path is available " Nilay Shroff
2026-01-30 18:20 ` [PATCH 5/7] nvme: export I/O failure " Nilay Shroff
2026-01-30 18:20 ` [PATCH 6/7] nvme: export controller reset event count " Nilay Shroff
2026-01-30 18:20 ` [PATCH 7/7] nvme: export controller reconnect " Nilay Shroff
2026-02-02 22:56 ` [PATCH 0/7] nvme: export additional diagnostic counters " Hannes Reinecke
2026-02-03 9:07 ` Nilay Shroff
2026-02-03 12:26 ` Ming Lei
2026-02-03 13:03 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aX0VgduYJckUaZ3O@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
--cc=wenxiong@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox