From: Keith Busch <kbusch@kernel.org>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: hch@lst.de, linux-nvme@lists.infradead.org, dwagner@suse.de,
hare@suse.de, jmeneghi@redhat.com, emilne@redhat.com,
mlombard@bsdbackstore.eu
Subject: Re: [PATCH V3 1/1] nvme: add support for dynamic quirk configuration via module parameter
Date: Wed, 4 Feb 2026 19:10:02 -0700 [thread overview]
Message-ID: <aYP7-r3gdSjImhg4@kbusch-mbp> (raw)
In-Reply-To: <20260204105555.173661-2-mlombard@redhat.com>
On Wed, Feb 04, 2026 at 11:55:55AM +0100, Maurizio Lombardi wrote:
> Introduce support for enabling or disabling specific NVMe quirks at module
> load time through the `quirks` module parameter.
> This mechanism allows users to apply known quirks dynamically based on the
> device's PCI vendor and device IDs, without requiring to add hardcoded
> entries in the driver and recompiling the kernel.
>
> While the generic PCI new_id sysfs interface exists for dynamic
> configuration, it is insufficient for scenarios where the system fails
> to boot (for example, this has been reported to happen because of the
> bogus_nid quirk). The new_id attribute is writable only after the system
> has booted and sysfs is mounted.
>
> The `quirks` parameter accepts a list of quirk specifications separated by
> a '-' character in the following format:
>
> <VID>:<DID>:<quirk_names>[-<VID>:<DID>:<quirk_names>-..]
>
> Each quirk is represented by its name and can be prefixed with `^` to
> indicate that the quirk should be disabled; quirk names are separated by
> a ',' character.
>
> Example: enable BOGUS_NID and BROKEN_MSI, disable DEALLOCATE_ZEROES:
>
> $ modprobe nvme quirks=7170:2210:bogus_nid,broken_msi,^deallocate_zeroes
Thanks, applied to nvme-7.0.
prev parent reply other threads:[~2026-02-05 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 10:55 [PATCH V3 0/1] Enable/Disable NVMe quirks via module parameter Maurizio Lombardi
2026-02-04 10:55 ` [PATCH V3 1/1] nvme: add support for dynamic quirk configuration " Maurizio Lombardi
2026-02-04 11:05 ` Christoph Hellwig
2026-02-05 2:10 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYP7-r3gdSjImhg4@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=dwagner@suse.de \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jmeneghi@redhat.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@bsdbackstore.eu \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox