From: Keith Busch <kbusch@kernel.org>
To: Justin Tee <justintee8345@gmail.com>
Cc: linux-nvme@lists.infradead.org,
Aristeu Rozanski <aris@redhat.com>,
Daniel Wagner <wagi@kernel.org>,
"Ewan D . Milne" <emilne@redhat.com>
Subject: Re: [PATCH 1/1] nvmet-fcloop: Check remoteport port_state before calling done callback
Date: Thu, 26 Feb 2026 15:36:18 -0700 [thread overview]
Message-ID: <aaDK4lB7Xw-dhqa0@kbusch-mbp> (raw)
In-Reply-To: <20251204202613.14908-1-justintee8345@gmail.com>
On Thu, Dec 04, 2025 at 12:26:13PM -0800, Justin Tee wrote:
> In nvme_fc_handle_ls_rqst_work, the lsrsp->done callback is only set when
> remoteport->port_state is FC_OBJSTATE_ONLINE. Otherwise, the
> nvme_fc_xmt_ls_rsp's LLDD call to lport->ops->xmt_ls_rsp is expected to
> fail and the nvme-fc transport layer itself will directly call
> nvme_fc_xmt_ls_rsp_free instead of relying on LLDD's done callback to free
> the lsrsp resources.
>
> Update the fcloop_t2h_xmt_ls_rsp routine to check remoteport->port_state.
> If online, then lsrsp->done callback will free the lsrsp. Else, return
> -ENODEV to signal the nvme-fc transport to handle freeing lsrsp.
Thanks, queued up for nvme-7.0.
prev parent reply other threads:[~2026-02-26 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 20:26 [PATCH 1/1] nvmet-fcloop: Check remoteport port_state before calling done callback Justin Tee
2025-12-05 12:31 ` Daniel Wagner
2025-12-05 14:02 ` Aristeu Rozanski
2025-12-05 19:38 ` Justin Tee
2026-02-26 22:36 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaDK4lB7Xw-dhqa0@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=aris@redhat.com \
--cc=emilne@redhat.com \
--cc=justintee8345@gmail.com \
--cc=linux-nvme@lists.infradead.org \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox