Re: [PATCHv2] nvmet-passthru: clear EUID/NGUID/UUID while using loop target

[Nilay Shroff <nilay@linux.ibm.com>]

Hi Keith,

A gentle ping about this patch. Does this now look good to you? 

Thanks,
--Nilay

On 9/24/24 09:04, Chaitanya Kulkarni wrote:
> On 9/21/2024 12:05 AM, Nilay Shroff wrote:
>> When nvme passthru is configured using loop target, the clear_ids
>> attribute is, by default, set to true. This attribute would ensure that
>> EUID/NGUID/UUID is cleared for the loop passthru target.
>>
>> The newer NVMe disk supporting the NVMe spec 1.3 or higher, typically,
>> implements the support for "Namespace Identification Descriptor list"
>> command. This command when issued from host returns EUID/NGUID/UUID
>> assigned to the inquired namespace. Not clearing these values, while
>> using nvme passthru using loop target, would result in NVMe host driver
>> rejecting the namespace. This check was implemented in the commit
>> 2079f41ec6ff ("nvme: check that EUI/GUID/UUID are globally unique").
>>
>> The fix implemented in this commit ensure that when host issues ns-id
>> descriptor list command, the EUID/NGUID/UUID are cleared by passthru
>> target. In fact, the function nvmet_passthru_override_id_descs() which
>> clears those unique ids already exits, so we just need to ensure that
>> ns-id descriptor list command falls through the corretc code path. And
>> while we're at it, we also combines the three passthru admin command
>> cases together which shares the same code.
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
>> ---
> 
> Looks good.
> 
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> 
> -ck
> 
>