From: Keith Busch <kbusch@kernel.org>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: linux-nvme@lists.infradead.org, dwagner@suse.de,
yjshin0438@gmail.com, hare@suse.de, sagi@grimberg.me,
chaitanyak@nvidia.com, mlombard@arkamax.eu
Subject: Re: [PATCH 2/2] nvmet-tcp: remove redundant calls to nvmet_tcp_fatal_error()
Date: Wed, 11 Mar 2026 14:23:26 -0600 [thread overview]
Message-ID: <abHPPoXg0Z1CZbQP@kbusch-mbp> (raw)
In-Reply-To: <20260311160920.465209-3-mlombard@redhat.com>
On Wed, Mar 11, 2026 at 05:09:20PM +0100, Maurizio Lombardi wrote:
> Executing nvmet_tcp_fatal_error() is generally the responsibility
> of the caller (nvmet_tcp_try_recv); all other functions should
> just return the error code.
Looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2026-03-11 20:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 16:09 [PATCH 0/2] nvmet-tcp: fix receive path error handling and state machine Maurizio Lombardi
2026-03-11 16:09 ` [PATCH 1/2] nvmet-tcp: propagate nvmet_tcp_build_pdu_iovec() errors to its callers Maurizio Lombardi
2026-03-11 20:20 ` Keith Busch
2026-03-11 16:09 ` [PATCH 2/2] nvmet-tcp: remove redundant calls to nvmet_tcp_fatal_error() Maurizio Lombardi
2026-03-11 20:23 ` Keith Busch [this message]
2026-03-13 5:58 ` [PATCH 0/2] nvmet-tcp: fix receive path error handling and state machine yunje shin
2026-03-13 11:17 ` Maurizio Lombardi
2026-03-13 12:16 ` Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abHPPoXg0Z1CZbQP@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@arkamax.eu \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
--cc=yjshin0438@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox