From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8742F112588E for ; Wed, 11 Mar 2026 20:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R6zR1jrc0unBPCKXHH+uO6AQgWpdzpjvbEd81+Z9V6A=; b=dzaERuX44qMXEOxMtMjO38TnT/ V7EiEvty9vj2Pc530nh3Zn2r5/DbsFVTz6TGbdBcLmYSaBQcm8KLQr0KAme7NtgTwxRVqLAPGzDqc m6jpcdoNmDCiftdRw7uMhWWORdUHXKq4td/O/yA0xc44JwEt/QqYRfuoJqacRP6YvtygSmcnKeFjH HobjAQGuyNsW/P9nt8xKpifyM1mizHGc6aXrry2JOtIzjA6LHl/UStbJmBGckEjp8VbDNFRtgTYAg ygYE55YHINHzeZNuPrBv8AoLhm6xb26tOwRe0drtE6Frb3f6tj/bnGg9e0lW+79mI2OC0TY4rNosf 9h7cdhvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0Q5b-0000000CTcK-2ib0; Wed, 11 Mar 2026 20:23:31 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0Q5Z-0000000CTbp-11o7 for linux-nvme@lists.infradead.org; Wed, 11 Mar 2026 20:23:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C9E0043C86; Wed, 11 Mar 2026 20:23:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E6A0C4CEF7; Wed, 11 Mar 2026 20:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773260608; bh=R6zR1jrc0unBPCKXHH+uO6AQgWpdzpjvbEd81+Z9V6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TM/eu99yFO6Dam345u7GXfCaZN/KKwz89yaLyjwHUEz8jSB9vTKVqoTJT7hGOQcvh 3FdFcpzojgjzXoVyalb6cw3f3JLh8KKD5zMSrpEljSeg8zoGb1nFVELzc5ODXbOApO SOMOUWdGTtIIHFdW8qW76n4i5S/BYfW05HDuwRSs2JEvNMi35brqBvksdhY+LqEoax IMOiN74shkYf7lN+Lb1DxGQlfHaYtyzgeUN5P6Iyk8sEHL4jD/a35LEra1tykB8OjI MsVqSa0gb9Ya7o7V6adpcXcazaf5zFTUCWVn9k9eQIG5gY3qP/pdYiESYwUKIEC19z q8NTjeHtuVjXQ== Date: Wed, 11 Mar 2026 14:23:26 -0600 From: Keith Busch To: Maurizio Lombardi Cc: linux-nvme@lists.infradead.org, dwagner@suse.de, yjshin0438@gmail.com, hare@suse.de, sagi@grimberg.me, chaitanyak@nvidia.com, mlombard@arkamax.eu Subject: Re: [PATCH 2/2] nvmet-tcp: remove redundant calls to nvmet_tcp_fatal_error() Message-ID: References: <20260311160920.465209-1-mlombard@redhat.com> <20260311160920.465209-3-mlombard@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260311160920.465209-3-mlombard@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260311_132329_303988_0A2FD99F X-CRM114-Status: UNSURE ( 7.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Mar 11, 2026 at 05:09:20PM +0100, Maurizio Lombardi wrote: > Executing nvmet_tcp_fatal_error() is generally the responsibility > of the caller (nvmet_tcp_try_recv); all other functions should > just return the error code. Looks good. Reviewed-by: Keith Busch