From: kenneth.heitke@intel.com (Heitke, Kenneth)
Subject: [PATCH v2 3/7] devcoredump: allow to create several coredump files in one device
Date: Tue, 7 May 2019 11:35:28 -0600 [thread overview]
Message-ID: <aced1953-4ea2-c8b1-9ee9-068e92ae1f8a@intel.com> (raw)
In-Reply-To: <1557248314-4238-4-git-send-email-akinobu.mita@gmail.com>
On 5/7/2019 10:58 AM, Akinobu Mita wrote:
> @@ -292,6 +309,12 @@ void dev_coredumpm(struct device *dev, struct module *owner,
> if (device_add(&devcd->devcd_dev))
> goto put_device;
>
> + for (i = 0; i < devcd->num_files; i++) {
> + if (device_create_bin_file(&devcd->devcd_dev,
> + &devcd->files[i].bin_attr))
> + /* nothing - some files will be missing */;
Is the conditional necessary if you aren't going to do anything?
> + }
> +
> if (sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj,
> "failing_device"))
> /* nothing - symlink will be missing */;
next prev parent reply other threads:[~2019-05-07 17:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 16:58 [PATCH v2 0/7] nvme-pci: support device coredump Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 1/7] devcoredump: use memory_read_from_buffer Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 2/7] devcoredump: fix typo in comment Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 3/7] devcoredump: allow to create several coredump files in one device Akinobu Mita
2019-05-07 17:35 ` Heitke, Kenneth [this message]
2019-05-08 15:40 ` Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 4/7] nvme.h: add telemetry log page definisions Akinobu Mita
2019-05-07 17:28 ` Heitke, Kenneth
2019-05-08 15:42 ` Akinobu Mita
2019-05-07 17:52 ` Heitke, Kenneth
2019-05-08 15:54 ` Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 5/7] nvme: add facility to check log page attributes Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 6/7] nvme-pci: add device coredump support Akinobu Mita
2019-05-07 17:07 ` Keith Busch
2019-05-08 0:25 ` Minwoo Im
2019-05-08 16:02 ` Akinobu Mita
2019-05-07 17:44 ` Heitke, Kenneth
2019-05-07 20:31 ` Heitke, Kenneth
2019-05-07 21:22 ` Keith Busch
2019-05-08 15:56 ` Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 7/7] nvme-pci: trigger device coredump on command timeout Akinobu Mita
2019-05-07 17:43 ` [PATCH v2 0/7] nvme-pci: support device coredump Heitke, Kenneth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aced1953-4ea2-c8b1-9ee9-068e92ae1f8a@intel.com \
--to=kenneth.heitke@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox