From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87B63ECAAD8 for ; Tue, 30 Aug 2022 07:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5YNkzH2bAzxIaAdbg5kn+mcBX6u4vJUms8etz8covKk=; b=b/CzreFgXb/JBVmvQXr6COgmzn ENSSpK9/cWU7o3qQt0MI/7+dCoE/A9uD5xNOURZ9RAUrow0ejCxss9UWUxxvVaFXCZEc8qINXW9bW RUIwvlXgWXEDw+TJrMD+I1Jju7PsSVNSgyW0z7ZO+El/c2H6GgzTuOmOYGaYh2iNtyl/WR28Zjr15 384VB20BlqZSymverRJ8WHep19uqyzCIE+sTzJxU4fUaU/xRsBvavBApUSaJC6yf9LLtfo8R0lfwb Mqn5TspO+8JKG7VJVTeU3LTVs1q2kFB1klIHeMQxZJrWtzpixKpaDwNZ+QLd9r/UezF4oJR5Xm+Yc g3UAKrHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSvR7-00Ehpn-BM; Tue, 30 Aug 2022 07:13:25 +0000 Received: from out2.migadu.com ([2001:41d0:2:aacc::]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSvR4-00EhlU-75 for linux-nvme@lists.infradead.org; Tue, 30 Aug 2022 07:13:23 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1661843593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5YNkzH2bAzxIaAdbg5kn+mcBX6u4vJUms8etz8covKk=; b=tlQ4JHLcJ7pYci0tO+kD2PMlhwvdPBV55Ei4D1GpPXBbYpDEwHDvBLq95yZbz5HwJ+tfxs u8ks49DBvB8iK1uSAeIceJ543m2q9cZaCCy2zcILreRJEvn3oTfJc1A4kHul5dF2Zg1tRP cezHFm0o7mMCBw7izE+I2Vki9YnMFRQ= Date: Tue, 30 Aug 2022 15:13:01 +0800 MIME-Version: 1.0 Subject: Re: [PATCH blktests] nvme: add dh module requirement for tests that involve dh groups Content-Language: en-US To: Sagi Grimberg , Shinichiro Kawasaki Cc: "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , Hannes Reinecke References: <20220829083614.874878-1-sagi@grimberg.me> <20220830044632.j7k45lhdlyvksrxh@shindev> <05548286-8d18-e3b4-06db-640c9d6b1399@grimberg.me> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Jackie Liu In-Reply-To: <05548286-8d18-e3b4-06db-640c9d6b1399@grimberg.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220830_001322_431896_47C27ED2 X-CRM114-Status: UNSURE ( 8.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi Sagi. 在 2022/8/30 15:05, Sagi Grimberg 写道: > >> Hi Sagi, >> >> On Aug 29, 2022 / 11:36, Sagi Grimberg wrote: >>> Signed-off-by: Sagi Grimberg >>> --- >>>   tests/nvme/043 | 1 + >>>   tests/nvme/044 | 1 + >>>   tests/nvme/045 | 1 + >>>   3 files changed, 3 insertions(+) >>> >>> diff --git a/tests/nvme/043 b/tests/nvme/043 >>> index 381ae755f140..87273e5b414d 100755 >>> --- a/tests/nvme/043 >>> +++ b/tests/nvme/043 >>> @@ -16,6 +16,7 @@ requires() { >>>       _have_kernel_option NVME_TARGET_AUTH >>>       _require_nvme_trtype_is_fabrics >>>       _require_nvme_cli_auth >>> +    _have_driver dh_generic >>>   } >> >> Do you see failure without this check? > > Yes, if dh_generic is built as a module (CONFIG_CRYPTO_DH=m). Maybe I don't understand correctly, but I think when NVME_AUTH=y CONFIG_CRYPTO_DH can only be built in. -- Jackie Liu