From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de
Cc: linux-kernel@vger.kernel.org, Sven Peter <sven@svenpeter.dev>,
Orlando Chamberlain <redecorating@protonmail.com>,
Aditya Garg <gargaditya08@live.com>
Subject: Re: [PATCH] nvme: add command id quirk for apple controllers
Date: Mon, 27 Sep 2021 09:39:29 -0600 [thread overview]
Message-ID: <aea8dabd-4c5f-3183-89a3-b2019d004ded@kernel.dk> (raw)
In-Reply-To: <20210927153539.372986-1-kbusch@kernel.org>
On 9/27/21 9:35 AM, Keith Busch wrote:
> @@ -1026,7 +1027,8 @@ blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req)
> return BLK_STS_IOERR;
> }
>
> - nvme_req(req)->genctr++;
> + if (!ctrl->quirks & NVME_QUIRK_SKIP_CID_GEN)
> + nvme_req(req)->genctr++;
This doesn't look right, as it'll never be true...
--
Jens Axboe
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-09-27 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 15:35 [PATCH] nvme: add command id quirk for apple controllers Keith Busch
2021-09-27 15:39 ` Jens Axboe [this message]
2021-09-29 15:02 ` kernel test robot
2021-09-29 15:14 ` kernel test robot
2021-09-29 15:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aea8dabd-4c5f-3183-89a3-b2019d004ded@kernel.dk \
--to=axboe@kernel.dk \
--cc=gargaditya08@live.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=redecorating@protonmail.com \
--cc=sagi@grimberg.me \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox