From: Christoph Hellwig <hch@infradead.org>
To: Rohit Chavan <roheetchavan@gmail.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages
Date: Wed, 6 May 2026 22:32:05 -0700 [thread overview]
Message-ID: <afwj1aZteJRqnKxs@infradead.org> (raw)
In-Reply-To: <20260504123555.1741525-1-roheetchavan@gmail.com>
On Mon, May 04, 2026 at 06:05:55PM +0530, Rohit Chavan wrote:
> pr_err("queue %d: data digest mismatch host: %s ctrl: %s\n",
> nvme_tcp_queue_id(queue),
> - queue->data_digest ? "enabled" : "disabled",
> - ctrl_ddgst ? "enabled" : "disabled");
> + str_enabled_disabled(queue->data_digest),
> + str_enabled_disabled(ctrl_ddgst));
I can't really see how this is considered an improvement.
next prev parent reply other threads:[~2026-05-07 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 12:35 [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages Rohit Chavan
2026-05-07 5:32 ` Christoph Hellwig [this message]
2026-05-08 9:47 ` Rohit Chavan
2026-05-11 8:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afwj1aZteJRqnKxs@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=roheetchavan@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox