From: Keith Busch <kbusch@kernel.org>
To: "Achkinazi, Igor" <Igor.Achkinazi@dell.com>
Cc: "hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] nvme-multipath: set BIO_REMAPPED on bios remapped to per-path namespace disks
Date: Thu, 28 May 2026 12:19:12 -0600 [thread overview]
Message-ID: <ahiHIEhsV2zuG5vH@kbusch-mbp> (raw)
In-Reply-To: <DS0PR19MB76963295FC34844B413479F9FD092@DS0PR19MB7696.namprd19.prod.outlook.com>
On Thu, May 28, 2026 at 03:24:27PM +0000, Achkinazi, Igor wrote:
> The SRCU read lock prevents synchronize_srcu() from completing, but
> does not prevent set_capacity(0) from executing. The bio fails the
> EOD check before it reaches the NVMe driver, so nvme_failover_req()
> never gets a chance to redirect it to another path of multipath. IO errors
> are reported to the application despite another path being available.
I double checked the sequences here, and yes, I think the
synchronize_srcu's already in place ensure every caller sees the EOD
error before it could fail the bio_queue_enter(), so this looks like it
happens to be sufficient. I'm okay with it.
next prev parent reply other threads:[~2026-05-28 18:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 14:52 [PATCH] nvme-multipath: set BIO_REMAPPED on bios remapped to per-path namespace disks Achkinazi, Igor
2026-05-18 19:23 ` Keith Busch
2026-05-18 20:59 ` Achkinazi, Igor
2026-05-18 21:52 ` Keith Busch
2026-05-20 20:27 ` Achkinazi, Igor
2026-05-19 6:53 ` hch
2026-05-19 19:10 ` Keith Busch
2026-05-28 15:24 ` [PATCH v2] " Achkinazi, Igor
2026-05-28 18:19 ` Keith Busch [this message]
2026-05-29 1:32 ` Achkinazi, Igor
2026-05-29 23:08 ` Keith Busch
2026-05-30 14:37 ` Achkinazi, Igor
2026-05-29 6:45 ` Hannes Reinecke
2026-05-30 14:34 ` Achkinazi, Igor
2026-06-01 7:06 ` Hannes Reinecke
2026-06-01 7:13 ` hch
2026-06-02 10:25 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahiHIEhsV2zuG5vH@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=Igor.Achkinazi@dell.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox