Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: John Garry <john.g.garry@oracle.com>
Cc: hch@lst.de, sagi@grimberg.me, axboe@fb.com,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: quieten sparse warning in valid LBA size check
Date: Mon, 8 Jun 2026 15:30:10 -0600	[thread overview]
Message-ID: <aic0Yv_gO4sBkTeM@kbusch-mbp> (raw)
In-Reply-To: <20260604145840.948130-1-john.g.garry@oracle.com>

On Thu, Jun 04, 2026 at 02:58:40PM +0000, John Garry wrote:
> Currently building with C=1 generates the following warning:
> 
>   CC      drivers/nvme/host/core.o
>   CHECK   drivers/nvme/host/core.c
> drivers/nvme/host/core.c:2426:13: warning: unsigned value that used to be signed checked against zero?
> drivers/nvme/host/core.c:2426:13: signed value source
> 
> This issue was introduced when using check_shl_overflow() to check for
> invalid LBA size. Sparse is having trouble dealing with __bitwise __le64
> conversion when passing to check_shl_overflow().
> 
> Resolve the issue by moving the check_shl_overflow() call to a separate
> function, where types are not converted.

Thanks, applied to nvme-7.2.


      parent reply	other threads:[~2026-06-08 21:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 14:58 [PATCH] nvme: quieten sparse warning in valid LBA size check John Garry
2026-06-05  6:52 ` Christoph Hellwig
2026-06-08 21:30 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aic0Yv_gO4sBkTeM@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=john.g.garry@oracle.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox