From: Keith Busch <kbusch@kernel.org>
To: John Garry <john.g.garry@oracle.com>
Cc: hch@lst.de, sagi@grimberg.me, axboe@fb.com,
linux-nvme@lists.infradead.org, mlombard@redhat.com
Subject: Re: [PATCH] nvme: make nvme_add_ns{_head}_cdev return void
Date: Wed, 10 Jun 2026 08:33:17 -0600 [thread overview]
Message-ID: <ail1rSmWLuYVErO1@kbusch-mbp> (raw)
In-Reply-To: <20260610111608.3252988-1-john.g.garry@oracle.com>
On Wed, Jun 10, 2026 at 11:16:08AM +0000, John Garry wrote:
> The return code from nvme_add_ns_head_cdev() and nvme_add_ns_cdev() is
> never checked, so make those functions return void.
>
> A cdev add failure is tolerated during initialization, and flags
> NVME_NS_CDEV_LIVE and NVME_NSHEAD_CDEV_LIVE are for determining whether
> a cdev needs to be deleted during un-initialization.
Thanks, applied to nvme-7.2.
prev parent reply other threads:[~2026-06-10 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 11:16 [PATCH] nvme: make nvme_add_ns{_head}_cdev return void John Garry
2026-06-10 11:33 ` Hannes Reinecke
2026-06-10 11:58 ` Christoph Hellwig
2026-06-10 14:33 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ail1rSmWLuYVErO1@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox