From: Keith Busch <kbusch@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-nvme@lists.infradead.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH] nvme-auth: Avoid C=1 warning in nvme_auth_derive_tls_psk()
Date: Mon, 6 Jul 2026 12:55:38 -0600 [thread overview]
Message-ID: <akv6KmKqp2y5MHPS@kbusch-mbp> (raw)
In-Reply-To: <20260625175911.35094-1-ebiggers@kernel.org>
On Thu, Jun 25, 2026 at 10:59:11AM -0700, Eric Biggers wrote:
> The following works fine with gcc and clang, but sparse warns about
> label_len not being an actual constant expression:
>
> const size_t label_len = sizeof(label) - 1;
> ...
> static_assert(label_len <= 255);
>
> Avoid this by giving label an explicit length and using sizeof(label)
> instead of label_len.
Thanks, applied to nvme-7.3.
prev parent reply other threads:[~2026-07-06 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 17:59 [PATCH] nvme-auth: Avoid C=1 warning in nvme_auth_derive_tls_psk() Eric Biggers
2026-06-26 7:53 ` John Garry
2026-07-01 11:04 ` Hannes Reinecke
2026-07-06 18:55 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akv6KmKqp2y5MHPS@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox