Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: "Zeng, Jun1" <jun1.zeng@intel.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
	"Cao, Gang" <gang.cao@intel.com>,
	"Jin, Jun I" <jun.i.jin@intel.com>,
	"Hu, Yong" <yong.hu@intel.com>
Subject: Re: [PATCH v1 0/1] nvme-pci: adaptive interrupt coalescing
Date: Mon, 20 Jul 2026 08:53:11 -0600	[thread overview]
Message-ID: <al42VxiRTKzTtMf5@kbusch-mbp> (raw)
In-Reply-To: <DM4PR11MB5375E80B504445BEDD869E95B7C32@DM4PR11MB5375.namprd11.prod.outlook.com>

On Mon, Jul 20, 2026 at 05:24:12AM +0000, Zeng, Jun1 wrote:
> > >On 7/15/26 12:57 AM, Jun Zeng wrote:
> > > The IOPS for small IO can be significantly improved when enabling 
> > > interrupt coalescing in this case. However, in some cases (e.g., big 
> > > IO for bandwidth or latency-sensitive tests with small IO and small 
> > > queue depth), interrupt coalescing has side effects.
> > > 
> > > Solution
> > > ========
> > > 
> > > Monitor the IOPS and average queue depth of inflight IO periodically 
> > > on each NVMe drive and enable/disable interrupt coalescing 
> > > automatically without user intervention. This feature is enabled by 
> > > default and can be disabled/enabled through debugfs during runtime.
> 
> > An algorithm like the above can be implemented more efficiently in NVMe controller hardware than in software, isn't it?
> 
> Theoretically, this can be implemented in the NVMe controller's
> firmware, but we have no control over the strategies and decisions of
> NVMe vendors. We are simply making the best possible optimizations at
> the software level.

But the coalescing feature as it is is too coarse. There is/was some
proposal going through the nvme technical workgroup to improve it. I
really haven't had any time to participate in the standards work to say
if it's any better, but that's probably the forum to improve such things
across vendors.

I'm not sure what concern you have about distro support with respect to
just controlling this from user space. AFAIK, everything usable has
sysfs, and you can't stop passthrough ioctls, so everything you need
should be there.


  reply	other threads:[~2026-07-20 14:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15  7:57 [PATCH v1 0/1] nvme-pci: adaptive interrupt coalescing Jun Zeng
2026-07-15  7:57 ` [PATCH v1 1/1] " Jun Zeng
2026-07-16 20:52   ` Keith Busch
2026-07-17  1:10     ` Zeng, Jun1
2026-07-17  8:06       ` Shevchenko, Andriy
2026-07-20 15:05     ` Christoph Hellwig
2026-07-20 15:25       ` Keith Busch
2026-07-21  8:37       ` Fengnan Chang
2026-07-21 10:07         ` Andy Shevchenko
2026-07-21 15:11         ` Keith Busch
2026-07-22  2:22           ` changfengnan
2026-07-22  9:04             ` Christoph Hellwig
2026-07-17 17:06 ` [PATCH v1 0/1] " Bart Van Assche
2026-07-20  5:24   ` Zeng, Jun1
2026-07-20 14:53     ` Keith Busch [this message]
2026-07-20 14:59   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=al42VxiRTKzTtMf5@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=gang.cao@intel.com \
    --cc=hch@lst.de \
    --cc=jun.i.jin@intel.com \
    --cc=jun1.zeng@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=yong.hu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox