From: Keith Busch <kbusch@kernel.org>
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: stable@vger.kernel.org, gregkh@linuxfoundation.org, hch@lst.de,
sagi@grimberg.me, roger.pau@citrix.com, phil@raspberrypi.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 6.18.y] nvme-pci: DMA unmap the correct regions in nvme_free_sgls
Date: Tue, 14 Jul 2026 15:16:28 -0600 [thread overview]
Message-ID: <alanLCR3Gew9Fuac@kbusch-mbp> (raw)
In-Reply-To: <20260714201342.1347823-1-nb@tipi-net.de>
On Tue, Jul 14, 2026 at 10:13:42PM +0200, Nicolai Buchwitz wrote:
> From: Roger Pau Monne <roger.pau@citrix.com>
>
> commit a54afbc8a2138f8c2490510cf26cde188d480c43 upstream.
>
> The call to nvme_free_sgls() in nvme_unmap_data() has the sg_list and sge
> parameters swapped. This wasn't noticed by the compiler because both share
> the same type. On a Xen PV hardware domain, and possibly any other
> architectures that takes that path, this leads to corruption of the NVMe
> contents.
>
> Fixes: f0887e2a52d4 ("nvme-pci: create common sgl unmapping helper")
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> [nb: drop the attrs parameter added in 6.19 by commit 61d43b1731e0
> ("nvme-pci: migrate to dma_map_phys instead of map_page"), which is
> not in 6.18.y]
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
Yes, definitely want this for LTS.
Acked-by: Keith Busch <kbusch@kernel.org>
prev parent reply other threads:[~2026-07-14 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 20:13 [PATCH 6.18.y] nvme-pci: DMA unmap the correct regions in nvme_free_sgls Nicolai Buchwitz
2026-07-14 21:16 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alanLCR3Gew9Fuac@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=nb@tipi-net.de \
--cc=phil@raspberrypi.com \
--cc=roger.pau@citrix.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox