Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-user: Minor enhancement and fixes
Date: Tue, 4 Nov 2014 14:52:24 +0000 (UTC)	[thread overview]
Message-ID: <alpine.LNX.2.00.1411041448290.4225@localhost.lm.intel.com> (raw)
In-Reply-To: <005601cff83d$63f09b40$2bd1d1c0$@samsung.com>

On Tue, 4 Nov 2014, Swati wrote:
>>>  - During Format, if LBA Format Metadata Size(MS) is 0, set Metadata
> Settings to Extended LBA.
>
>> Why? This is what sets identify namespace's FLBAS bit 4. The 1.1b spec
>> clarified this bit is not applicable when metadata size is 0.
>
> As this was not clear before the 1.1b Spec, we have f/w where, if Metadata
> Size is 0 and this bit is not set, the format command fails with error
> status code Ah (enabling metadata to be transferred as part of a separate
> buffer when there is no metadata supported as part of the format selected)
>
> So can we have metadata handling, based on the spec version supported by the
> device?

Instead of assuming all devices prior to 1.1b's clarification have the
same broken behavoir, let's just make this a user settable value.

      reply	other threads:[~2014-11-04 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30 10:20 [PATCH] nvme-user: Minor enhancement and fixes Swati C
2014-10-30 13:31 ` Keith Busch
2014-11-04 14:41   ` Swati
2014-11-04 14:52     ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1411041448290.4225@localhost.lm.intel.com \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox