From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Add SCSI VPD Block Limits Translation
Date: Fri, 5 Dec 2014 15:49:24 +0000 (UTC) [thread overview]
Message-ID: <alpine.LNX.2.00.1412051545590.4225@localhost.lm.intel.com> (raw)
In-Reply-To: <CANvN+emdi6+dW7YQV6+3MqZqwgiwHADTdOVswmN34p24p2U6vQ@mail.gmail.com>
On Fri, 5 Dec 2014, Andrey Kuzmin wrote:
> On Dec 5, 2014 3:14 AM, "Keith Busch" <keith.busch@intel.com> wrote:
>> -#define INQ_NUM_SUPPORTED_VPD_PAGES 5
>> +#define INQ_NUM_SUPPORTED_VPD_PAGES 6
>> #define VERSION_SPC_4 0x06
>> #define ACA_UNSUPPORTED 0
>> #define STANDARD_INQUIRY_LENGTH 36
>
> Are there any specific reasons for the above SPC-4 stuff to be defined
> in the nvme driver instead of include/scsi where it seems to
> (naturally) belong? Just my 0.02 :).
There is a lot of scsi cruft in the nvme driver, but I'm sticking to
the local convention here until a refactor (which is coming later!).
prev parent reply other threads:[~2014-12-05 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 0:13 [PATCH] NVMe: Add SCSI VPD Block Limits Translation Keith Busch
2014-12-05 0:13 ` [PATCHv2] NVMe: Update SCSI Inquiry VPD 83 translation Keith Busch
2014-12-16 15:55 ` Matthew Wilcox
2014-12-16 16:39 ` Keith Busch
2014-12-17 14:46 ` Matthew Wilcox
2014-12-05 14:03 ` [PATCH] NVMe: Add SCSI VPD Block Limits Translation Andrey Kuzmin
2014-12-05 15:49 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1412051545590.4225@localhost.lm.intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox