From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@intel.com (Keith Busch) Date: Wed, 28 Jan 2015 15:11:09 +0000 (UTC) Subject: [PATCH] NVMe: Skip namespaces with interleaved meta-data In-Reply-To: References: <1422382021-15350-1-git-send-email-keith.busch@intel.com> <1422395867952.40819@hgst.com> Message-ID: On Tue, 27 Jan 2015, Martin K. Petersen wrote: >>>>>> "Keith" == Keith Busch writes: > Keith, > > Keith> I can't register with the blk-integrity extentions until after > Keith> add_disk is completed because the disk's kobj needs to be > Keith> initialized before blk_integrity_register. The 'add_disk' itself > Keith> submits a lot of reads, though. Am I missing something, or how > Keith> could those succeed when the block device's required integrity > Keith> format hasn't been setup? > > Protection is optional and enabled on a per-I/O basis. Even if the block > layer's auto protection is enabled it is normal to see a flutter of > unprotected reads while partitions are being scanned. Thanks for the info. NVMe doesn't appear to allow disabling metadata per-io except for a subset of formats. If that's correct, this driver would have to provide a valid protection buffer for all IO. Checking with committee comrades for clarification.