From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 2/4] NVMe: Decouple nvmeq hctx from ns request queue
Date: Tue, 19 May 2015 15:51:32 +0000 (UTC) [thread overview]
Message-ID: <alpine.LNX.2.00.1505191544580.15930@localhost.lm.intel.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1505191519450.15930@localhost.lm.intel.com>
On Tue, 19 May 2015, Keith Busch wrote:
> <snip> and the blk-mq layer takes an hctx to iterate through busy tags
> I'm actually not sure why every request queue has their own hardware
> context. Shouldn't it be an artifact of the tagset rather than the
> request queue? I thought I might have a chance of intercepting a late
> 4.1 rc if I didn't mess with the block layer, though.
Oh no!, the blk_mq_tag_busy_iter usage is broken in the nvme driver for
anything with more than one namespace, and broken with the implementation
I suggested. It only invokes the callback if the hctx is assocaited with
the same request queue. Must fix, maybe add a blk-mq api to iterate the
tagset rather than hctx.
next prev parent reply other threads:[~2015-05-19 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 19:30 [PATCH 0/4] Namespace handling updates and fixes Keith Busch
2015-05-18 19:30 ` [PATCH 1/4] blk: Define blk_set_queue_dying in header Keith Busch
2015-05-18 19:30 ` [PATCH 2/4] NVMe: Decouple nvmeq hctx from ns request queue Keith Busch
2015-05-19 7:46 ` Christoph Hellwig
2015-05-19 15:35 ` Keith Busch
2015-05-19 15:51 ` Keith Busch [this message]
2015-05-19 16:15 ` Christoph Hellwig
2015-05-19 16:14 ` Christoph Hellwig
2015-05-18 19:30 ` [PATCH 3/4] NVMe: Automatic namespace rescan Keith Busch
2015-05-18 19:30 ` [PATCH 4/4] NVMe: Remove disks before shutdown Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1505191544580.15930@localhost.lm.intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox