From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Fix obtaining command result
Date: Tue, 26 May 2015 15:16:47 +0000 (UTC) [thread overview]
Message-ID: <alpine.LNX.2.00.1505261512120.15930@localhost.lm.intel.com> (raw)
In-Reply-To: <20150523130150.GA18701@lst.de>
On Sat, 23 May 2015, Christoph Hellwig wrote:
> On Fri, May 22, 2015@12:28:31PM -0600, Keith Busch wrote:
>> Replaces req->sense_len usage, which is not owned by the LLD, to
>> req->special to contain the command result for driver created commands,
>> and sets the result unconditionally on completion.
>
> Thanks Keith,
>
> sorry for the mess, after porting this from my series to use replace
> the BLOCK_PC specific fields to mainline I only tested this on Qemu
> which only has a single queue. I'll make sure to always do final
> testing on real hardware as well.
No problem, it's a good enhancement overall and caught early enough,
so no a big deal. Break and fix cycles are better than doing nothing. :)
BTW, the qemu nvme block device *should* be multi-queue capable if you
allocate multiple CPUs (-smp <cpus>) to your guest. It works in my tree
at least, so I hope it works in qemu mainline. Maybe I'll have time this
week to look at that.
prev parent reply other threads:[~2015-05-26 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 18:28 [PATCH] NVMe: Fix obtaining command result Keith Busch
2015-05-22 20:14 ` Jens Axboe
2015-05-23 13:01 ` Christoph Hellwig
2015-05-26 15:16 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1505261512120.15930@localhost.lm.intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox