From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Set affinity after allocating request queues
Date: Fri, 4 Sep 2015 15:12:29 +0000 (UTC) [thread overview]
Message-ID: <alpine.LNX.2.00.1509041505230.23840@localhost.lm.intel.com> (raw)
In-Reply-To: <000101d0e6e8$d7a74850$86f5d8f0$@samsung.com>
On Fri, 4 Sep 2015, ??? wrote:
> Hello, Keith Busch.
> Thank you for the patch. I've confirmed that setting hint is now working with the patch.
>
> However, I think setting affinity hint is not sufficient to balance interrupts.
> We've observed that affinity hint has not much impact on distributing interrupts across cores on a distro such as debian 7.0
> while setting affinity directly has worked on the distro.
>
> Plus, hint information is also provided by device driver with intention that balances interrupt loads across cores.
> And it also needs to collaborate with irqbalance option to work on.
> So, I think setting affinity is a clear way to achieve balancing effect provided by driver rather than hint information.
> I hope to listen your opinion regarding this.
No argument from me against having an API to directly set the irq
affinity. I think it's a great idea.
This patch just puts the hint where it ought to be. My machines have a
different patch that create a request_queue without a namespace (for
hidden access), so I didn't notice the async scanning broke the hint
on mainline.
With this patch, and when the new irq affinity set function is
exported (assuming that is being done), you can just change the
irq_set_affinity_hint() to the new function.
next prev parent reply other threads:[~2015-09-04 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 14:18 [PATCH] NVMe: Set affinity after allocating request queues Keith Busch
2015-09-04 8:08 ` 김경산
2015-09-04 15:12 ` Keith Busch [this message]
2015-09-23 20:37 ` Keith Busch
2015-09-23 20:40 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1509041505230.23840@localhost.lm.intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox