Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: Tree updated 2013-05-29
Date: Wed, 29 May 2013 14:44:31 -0600 (MDT)	[thread overview]
Message-ID: <alpine.LRH.2.03.1305291342320.12919@localhost.localdom> (raw)
In-Reply-To: <20130529210419.GE8211@linux.intel.com>

On Wed, 29 May 2013, Matthew Wilcox wrote:
> Chayan Biswas (1):
>      Return the result from user admin command IOCTL even in case of failure
>
> Matthew Wilcox (1):
>      NVMe: Use dma_set_mask() correctly
>
> Ramachandra Rao Gajula (1):
>      NVMe: Add MSI support
>
> I'll ask Linus to pull on Friday.  Please test.

In the MSI patch, there's a missing 'break' after the 'result == 0' case.
Otherwise everything looks good to me.

diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index 584586f..ce79a59 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -1681,6 +1681,7 @@ static int nvme_setup_io_queues(struct nvme_dev *dev)
  			if (result == 0) {
  				for (i = 0; i < nr_io_queues; i++)
  					dev->entry[i].vector = i + pdev->irq;
+                               break;
  			} else if (result > 0) {
  				nr_io_queues = result;
  				continue;

      reply	other threads:[~2013-05-29 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17 13:35 Tree updated 2013-05-17 Matthew Wilcox
2013-05-29 21:04 ` Tree updated 2013-05-29 Matthew Wilcox
2013-05-29 20:44   ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.03.1305291342320.12919@localhost.localdom \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox