Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH v4] NVMe: basic conversion to blk-mq
Date: Fri, 30 May 2014 10:48:27 -0600 (MDT)	[thread overview]
Message-ID: <alpine.LRH.2.03.1405301027350.11244@AMR> (raw)
In-Reply-To: <1401400285-25003-2-git-send-email-m@bjorling.me>

On Thu, 29 May 2014, Matias Bj?rling wrote:
> This converts the current NVMe driver to utilize the blk-mq layer.

I'm pretty darn sure this new nvme_remove can cause a process
with an open reference to use queues after they're freed in the
nvme_submit_sync_command path, maybe even the admin tags too.

> @@ -2802,7 +2574,7 @@ static void nvme_remove(struct pci_dev *pdev)
> 	nvme_dev_remove(dev);
> 	nvme_dev_shutdown(dev);
> 	nvme_free_queues(dev, 0);
> -	rcu_barrier();
> +	nvme_free_admin_tags(dev);
> 	nvme_release_instance(dev);
> 	nvme_release_prp_pools(dev);
> 	kref_put(&dev->kref, nvme_free_dev);

  parent reply	other threads:[~2014-05-30 16:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 21:51 [PATCH v4] basic conversion to blk-mq Matias Bjørling
2014-05-29 21:51 ` [PATCH v4] NVMe: " Matias Bjørling
2014-05-30 14:54   ` Matthew Wilcox
2014-05-30 15:00   ` Matthew Wilcox
2014-05-30 19:46     ` Jens Axboe
2014-05-30 16:48   ` Keith Busch [this message]
2014-05-30 19:33     ` Matias Bjorling
2014-05-30 16:58   ` Matthew Wilcox
2014-06-02 10:08   ` Christoph Hellwig
2014-06-02 11:46     ` Matias Bjørling
2014-06-02  9:42 ` [PATCH v4] " Christoph Hellwig
2014-06-02 10:31   ` Matias Bjørling
2014-06-02 10:11 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.03.1405301027350.11244@AMR \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox