From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Fail SCSI->NVMe translation for UNMAP when anchor is set
Date: Wed, 18 Jun 2014 09:35:13 -0600 (MDT) [thread overview]
Message-ID: <alpine.LRH.2.03.1406180929180.4699@AMR> (raw)
In-Reply-To: <20140618152708.GH12025@linux.intel.com>
On Wed, 18 Jun 2014, Matthew Wilcox wrote:
> On Wed, Jun 18, 2014@09:13:27AM -0600, Keith Busch wrote:
>> On Wed, 18 Jun 2014, Dan McLeran wrote:
>>> SCSI UNMAP should fail if the host sends down the command with Anchor set. The
>>> current code does not check this condition. This patch checks Anchor and fails
>>> Scsi->NVMe translation if Anchor is set.
>>
>> The reference on nvmexpress.org says the command with anchor set is
>> premissible "for resource-provisioned devices".
>
> So ... we should check whether the namespace has NSFEAT bit 0 set before
> failing the command?
This gets a little confusing (for me, at least). The translation for
VPD B2 says the device is "resource-provisioned" if it supports DSM
Deallocate, but the command is already going to be failed by the device
if it doesn't support DSM.
prev parent reply other threads:[~2014-06-18 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 9:03 [PATCH] NVMe: Fail SCSI->NVMe translation for UNMAP when anchor is set Dan McLeran
2014-06-18 15:13 ` Keith Busch
2014-06-18 15:15 ` Dan McLeran
2014-06-18 15:27 ` Matthew Wilcox
2014-06-18 15:30 ` Dan McLeran
2014-06-18 15:45 ` Matthew Wilcox
2014-06-18 15:51 ` Mayes, Barrett N
2014-06-18 16:04 ` Keith Busch
2014-06-18 16:25 ` Matthew Wilcox
2014-06-18 17:23 ` Mayes, Barrett N
2014-06-18 15:35 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1406180929180.4699@AMR \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox