From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Change nvme_enable_ctrl behavior and track CC
Date: Fri, 20 Jun 2014 13:36:31 -0600 (MDT) [thread overview]
Message-ID: <alpine.LRH.2.03.1406201330220.4699@AMR> (raw)
In-Reply-To: <alpine.WNT.2.00.1406201147280.22288@DMCLERAN-DESK.amr.corp.intel.com>
On Fri, 20 Jun 2014, Dan McLeran wrote:
> nvme_probe as it is written today essentially clears out any the shutdown
> bits during enable. If you unload/reload the nvme module you'll see that the
> normal shutdown bits are set before the controller gets enabled. The
> nvme_remove path calls nvme_shutdown_ctrl but not nvme_disable_ctrl. Maybe
> the nvme_probe path should always disable the controller first before
> enabling to ensure we're starting clean?
But we already do that. We probably want nvme_disable_ctrl to also clear
the CC.SHN bits in addition to CC.EN, though.
next prev parent reply other threads:[~2014-06-20 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 15:42 [PATCH] NVMe: Change nvme_enable_ctrl behavior and track CC Dan McLeran
2014-06-20 17:13 ` Matthew Wilcox
2014-06-20 19:27 ` Dan McLeran
2014-06-20 19:36 ` Keith Busch [this message]
2014-06-20 19:42 ` Dan McLeran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1406201330220.4699@AMR \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox